fix(devicemanager): percision -> precision in motion calibration#10871
Open
mvanhorn wants to merge 1 commit into
Open
fix(devicemanager): percision -> precision in motion calibration#10871mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
`src/slic3r/GUI/DeviceManager.cpp` cases 36 and 37 displayed "Measuring motion percision" and "Enhancing motion percision" in the device status panel during motion calibration, visible to every user who triggered the routine. The intended word is "precision". Rename the source strings and update the matching `msgid` entries in all 18 `bbl/i18n/*.po` translation files so the existing `msgstr` translations still resolve via gettext lookup. Translations remain intact - only the lookup key matches the corrected source. Fixes bambulab#10856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10856. The device status panel rendered "Measuring motion percision" and "Enhancing motion percision" during motion calibration (cases 36/37 in
src/slic3r/GUI/DeviceManager.cpp:162,164). The intended word isprecision. This PR fixes the source strings and updates themsgidkeys in all 18bbl/i18n/*.pofiles to match, so existingmsgstrtranslations still resolve via gettext lookup.Why this matters
These two strings are visible to every user who triggers motion calibration, so the typo is high-visibility in the device status panel. Updating only
DeviceManager.cppwould silently break the gettext lookup for every translated locale (the existingmsgid "Measuring motion percision"entries no longer match the corrected source, so gettext falls back to English and translators' work is dropped on the floor until the next extraction cycle).Updating the
msgidkey on each.pofile at the same time as the source keeps the existingmsgstrtranslations attached to the corrected source string. Translators don't have to redo their work, and non-English users keep seeing translated text instead of falling back to the corrected English.Changes
src/slic3r/GUI/DeviceManager.cpp:162,164-percision->precisionin both_L(...)calls.bbl/i18n/{cs,de,en,es,fr,hu,it,ja,ko,nl,pl,pt_BR,ru,sv,tr,uk,zh_CN,zh_TW}/BambuStudio_*.po-msgidkeys updated to match. 18 files, 2 lines each.Total: 19 files, 38 added + 38 deleted lines. Mechanical search-and-replace of two exact strings.
How to test
The 18
.pofiles each have two updatedmsgidlines; the matchingmsgstrtranslations are untouched.Fixes #10856
AI-assisted.