Skip to content

fix: don't skip user presets when parent preset is not found #10875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenJule wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

fix: don't skip user presets when parent preset is not found #10875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/libslic3r/Preset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1453,8 +1453,13 @@ void PresetCollection::load_presets(
else {
auto inherits_config2 = dynamic_cast<ConfigOptionString *>(inherits_config);
if ((inherits_config2 && !inherits_config2->value.empty())) {
BOOST_LOG_TRIVIAL(error) << boost::format("can not find parent %1% for config %2%!") % inherits_config2->value % PathSanitizer::sanitize(preset.file);
continue;
// Parent preset not found (e.g. renamed or removed by a system update).
// Do NOT skip the preset — that would silently delete the user's work.
// Fall back to the built-in default config so the user at least sees
// their preset and can correct any settings that differ from the old parent.
BOOST_LOG_TRIVIAL(warning) << boost::format(
"Parent preset '%1%' not found for '%2%'; loading with default config as fallback.")
% inherits_config2->value % PathSanitizer::sanitize(preset.file);
}
// We support custom root preset now
// Find a default preset for the config. The PrintPresetCollection provides different default preset based on the "printer_technology" field.
Expand Down