fix(deps): cmake_minimum_required ordering and MSVC 1950+ support for CMake 4.x compat#10876
fix(deps): cmake_minimum_required ordering and MSVC 1950+ support for CMake 4.x compat#10876BenJule wants to merge 3 commits into
Conversation
|
Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change. It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused. |
|
@lanewei120 LGTM |
|
Hi @BenJule We have recently fixed the github building issues, including CMake 4.x compatibility. |
|
Thanks @lanewei120 - checked against current master and both changes are already there: deps/CMakeLists.txt now has |
Summary
CMake 4.x requires
cmake_minimum_required()to appear beforeproject()indeps/CMakeLists.txt. Without this, builds with CMake 4.0+ fail with a fatal error.Also adds support for the new MSVC 1950+ toolset (Visual Studio 2026 / v144) in
deps-windows.cmake, as the existing code only recognized toolsets up to v143.deps/CMakeLists.txt: movecmake_minimum_required(VERSION 3.5)beforeproject()deps/deps-windows.cmake: addVERSION_GREATER_EQUAL 1950branch for MSVC v144 toolset detection