fix(deps): cmake_minimum_required ordering and MSVC 1950+ support for CMake 4.x compat#10876
Open
BenJule wants to merge 2 commits into
Open
fix(deps): cmake_minimum_required ordering and MSVC 1950+ support for CMake 4.x compat#10876BenJule wants to merge 2 commits into
BenJule wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMake 4.x requires
cmake_minimum_required()to appear beforeproject()indeps/CMakeLists.txt. Without this, builds with CMake 4.0+ fail with a fatal error.Also adds support for the new MSVC 1950+ toolset (Visual Studio 2026 / v144) in
deps-windows.cmake, as the existing code only recognized toolsets up to v143.deps/CMakeLists.txt: movecmake_minimum_required(VERSION 3.5)beforeproject()deps/deps-windows.cmake: addVERSION_GREATER_EQUAL 1950branch for MSVC v144 toolset detection