Skip to content

fix(deps): cmake_minimum_required ordering and MSVC 1950+ support for CMake 4.x compat #10876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BenJule wants to merge 3 commits into from
Closed

fix(deps): cmake_minimum_required ordering and MSVC 1950+ support for CMake 4.x compat #10876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9862a9
fix: cmake_minimum_required before project(), bump to 3.5 for CMake 4…
BenJule May 22, 2026
72a5393
fix: add MSVC 1950+ (VS2026/v144) support to deps-windows.cmake
BenJule May 22, 2026
a364e07
Merge branch 'master' into upstream/fix/cmake4-deps-compat
MackBambu Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
# therefore, unfortunately, the installation cannot be copied/moved elsewhere without re-installing wxWidgets.
#

cmake_minimum_required(VERSION 3.5)
project(BambuStudio-deps)
cmake_minimum_required(VERSION 3.2)

include(ExternalProject)
include(ProcessorCount)
Expand Down
4 changes: 2 additions & 2 deletions deps/deps-windows.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ elseif (MSVC_VERSION LESS 1950)
# 1930-1949 = VS 17.0 (v143 toolset)
set(DEP_VS_VER "17")
set(DEP_BOOST_TOOLSET "msvc-14.3")
elseif (MSVC_VERSION LESS 1960)
# 1950-1959 = VS 18.0 (v144 toolset)
elseif (MSVC_VERSION LESS 1970)
# 1950-1969 = VS 18.0 (v144 toolset)
set(DEP_VS_VER "18")
set(DEP_BOOST_TOOLSET "msvc-14.4")
else ()
Expand Down
Loading