Skip to content

fix: Linux packaging — copy desktop/icons for non-AppImage builds, prevent set -e exit #10878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenJule wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −1
Open

fix: Linux packaging — copy desktop/icons for non-AppImage builds, prevent set -e exit #10878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01128a8
fix: copy desktop file and icons into package/ for non-AppImage builds
BenJule May 21, 2026
4ebfee5
fix: prevent set -e exit when gtk3 not installed in container
BenJule May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion linux.d/debian
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FOUND_GTK3=$(dpkg -l libgtk* | grep gtk-3)
FOUND_GTK3=$(dpkg -l libgtk* | grep gtk-3 || true)

REQUIRED_DEV_PACKAGES=(
autoconf
Expand Down
8 changes: 8 additions & 0 deletions src/platform/unix/BuildLinuxImage.sh.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ echo -n "[9/9] Generating Linux app..."
# remove unneeded po from resources
## find package/resources/localization -name "*.po" -type f -delete ## FIXME: DD - do we need this?

# copy .desktop file and hicolor icons needed by system package builds
cp -f ../src/platform/unix/@SLIC3R_APP_KEY@.desktop package/@SLIC3R_APP_KEY@.desktop
for PNG_SIZE in 32 128 192; do
mkdir -p package/usr/share/icons/hicolor/${PNG_SIZE}x${PNG_SIZE}/apps
cp -f package/resources/images/@SLIC3R_APP_KEY@_${PNG_SIZE}px.png \
package/usr/share/icons/hicolor/${PNG_SIZE}x${PNG_SIZE}/apps/@SLIC3R_APP_KEY@.png
done

# create bin
cat << EOF >@SLIC3R_APP_CMD@
#!/bin/bash
Expand Down