Skip to content

fix: warn user when filament serial input sanitizes to empty string#10879

Open
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:upstream/fix/serial-validation
Open

fix: warn user when filament serial input sanitizes to empty string#10879
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:upstream/fix/serial-validation

Conversation

@BenJule
Copy link
Copy Markdown

@BenJule BenJule commented May 22, 2026

Summary

  • Show a warning message when the user enters a filament serial number that gets sanitized (trimmed/filtered) to an empty string, preventing silent data loss

Changes

  • src/slic3r/GUI/CreatePresetsDialog.cpp: Add validation that warns the user when serial input becomes empty after sanitization

Test plan

  • Enter a filament serial number consisting only of whitespace or invalid characters
  • Verify a warning is shown instead of silently saving an empty serial
  • Verify normal serial numbers still save correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant