fix: make the Helio icon visible in dark mode (#11308)#11328
Open
BenJule wants to merge 1 commit into
Open
Conversation
helio_icon_dark.svg (used in dark mode) was filled with #060606, i.e. almost black, so the icon was invisible against the dark toolbar. Match the light variant's white fill so it is visible on the dark background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11308. The Helio icon was nearly invisible in dark mode (see the screenshot in the issue - the round icon next to "Slice plate" blends into the dark toolbar).
Cause:
resources/images/helio_icon_dark.svg, which is the variantload_svg/BitmapCache::dark_version()selects in dark mode, was filled with#060606(almost black). On the dark toolbar that's invisible. The light-mode varianthelio_icon.svgis filled white.Fix: change the dark variant's fill from
#060606towhite, matching the light variant, so the icon is visible against the dark background.Test plan