Skip to content

fix: project description editor never loads, blocking project save (#11302) #11329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenJule wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: project description editor never loads, blocking project save (#11302) #11329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions resources/web/model_new/js/ckeditor_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,24 @@ const editorConfig = {
language: editorLanguage
};

script.onload = () => {
let editorsInitialized = false;
function initEditors() {
if (editorsInitialized) return;
editorsInitialized = true;
ClassicEditor.create(document.querySelector('#editor'), editorConfig).then( editor => {
window.projectEditor = editor;
});
ClassicEditor.create(document.querySelector('#profile-editor'), editorConfig).then( editor => {
window.profileEditor = editor;
});
};
}

// Initialise the editors once the translation file has loaded. If it fails to
// load (e.g. the resolved locale has no translation file such as "en-us", which
// happens when editor.html is opened without a ?lang= and the webview reports
// navigator.language as en-US), still initialise the editors so the description
// field is usable instead of leaving the page without an editor.
script.onload = initEditors;
script.onerror = initEditors;

document.head.appendChild(script);