feat: add fill bed with object instances#11514
Open
BenJule wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a separate Fill bed with instances action alongside the existing Fill bed with copies action.
The existing action continues to create independent object copies. The new action fills the remaining plate area with linked
ModelInstanceentries belonging to the selected object.Changes
FillBedJobfor instance creationModelObjectImplementation notes
Bambu Studio already contained the
fill_bed_with_instances()entry point, but it invoked the same copy-based fill-bed job.This change gives the fill-bed job an explicit copies/instances mode and registers separate persistent jobs for both operations.
Testing
FillBedJob.cppGUI_Factories.cppPlater.cppgit diff --checkNot tested:
Related to #496