Skip to content

fix: overhang slowdown with painted Fuzzy Skin modifiers#11530

Open
imaxdoll wants to merge 3 commits into
bambulab:masterfrom
imaxdoll:fix/fuzzy-skin-overhang-speed
Open

fix: overhang slowdown with painted Fuzzy Skin modifiers#11530
imaxdoll wants to merge 3 commits into
bambulab:masterfrom
imaxdoll:fix/fuzzy-skin-overhang-speed

Conversation

@imaxdoll

Copy link
Copy Markdown

Summary

Fixes #10389. Related to #4751.

This fixes a regression where applying Fuzzy Skin through a modifier or painted region disables percentage-based overhang speed detection.

When global Fuzzy Skin is None(allow paint), modifier/painted Fuzzy Skin can still populate perimeter_regions. The previous helper required perimeter_regions to be empty, so overhang-degree detection was disabled for affected layers even though global Fuzzy Skin was not enabled.

This restores the behavior from v02.05.00.66: overhang slowdown is allowed whenever global Fuzzy Skin is None, including when Fuzzy Skin is applied through modifier/painted regions.

Changes

  • Removed the pg.perimeter_regions->empty() requirement from fuzzy_skin_allows_overhang_slowdown.
  • Confirmed the corrected helper is used by both Classic and Arachne perimeter-generation paths.
  • Added a small Xcode 26 compatibility fix for wxMediaState constants by changing out-of-range enum constexpr values to inline const.

Scope

This is a minimal regression fix. It does not redesign the Fuzzy Skin/overhang-speed pipeline.

Global Fuzzy Skin modes such as External, All, and AllWalls keep the existing behavior where percentage-based overhang-degree detection is disabled. A broader fix for global Fuzzy Skin would likely require detecting/assigning overhang slowdown before applying Fuzzy Skin geometry, then preserving that speed metadata through fuzzy path generation.

Validation

  • Compared relevant behavior with v02.05.00.66.
  • Verified FuzzySkinType::None means None(allow paint).
  • Verified Classic and Arachne both gate overhang-degree handling through fuzzy_skin_allows_overhang_slowdown.
  • Ran:
git diff --check
./BuildMac.sh -a arm64 -c Release -s -x -b

Build completed successfully on macOS Apple Silicon with Xcode 26.

Notes

This does not change Fuzzy Skin geometry generation, configured overhang speed values, H2D nozzle logic, or process-profile logic.

No automated regression test was added because the affected helper is file-local and a meaningful test would require an integration slicing scenario with modifier/painted Fuzzy Skin and generated overhang-speed inspection.

@imaxdoll

Copy link
Copy Markdown
Author

Hi maintainers, this PR is ready for review.

It is intentionally scoped to one behavior change in PerimeterGenerator.cpp: restoring the v02.05.00.66 behavior where global FuzzySkinType::None allows percentage-based overhang slowdown even when modifier/painted Fuzzy Skin creates perimeter regions.

The PR diff is now limited to one line and no longer includes the unrelated Xcode 26 media header changes.

Could someone with write access approve the workflow run and review when available?

@imaxdoll imaxdoll changed the title Fix overhang slowdown with painted Fuzzy Skin modifiers fix: overhang slowdown with painted Fuzzy Skin modifiers Jul 17, 2026
@imaxdoll

Copy link
Copy Markdown
Author

@Haidiye00 Please suggest if anything should be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modifier impacting overhang speed

1 participant