fix: overhang slowdown with painted Fuzzy Skin modifiers#11530
Open
imaxdoll wants to merge 3 commits into
Open
fix: overhang slowdown with painted Fuzzy Skin modifiers#11530imaxdoll wants to merge 3 commits into
imaxdoll wants to merge 3 commits into
Conversation
Author
|
Hi maintainers, this PR is ready for review. It is intentionally scoped to one behavior change in The PR diff is now limited to one line and no longer includes the unrelated Xcode 26 media header changes. Could someone with write access approve the workflow run and review when available? |
Author
|
@Haidiye00 Please suggest if anything should be changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10389. Related to #4751.
This fixes a regression where applying Fuzzy Skin through a modifier or painted region disables percentage-based overhang speed detection.
When global Fuzzy Skin is
None(allow paint), modifier/painted Fuzzy Skin can still populateperimeter_regions. The previous helper requiredperimeter_regionsto be empty, so overhang-degree detection was disabled for affected layers even though global Fuzzy Skin was not enabled.This restores the behavior from
v02.05.00.66: overhang slowdown is allowed whenever global Fuzzy Skin isNone, including when Fuzzy Skin is applied through modifier/painted regions.Changes
pg.perimeter_regions->empty()requirement fromfuzzy_skin_allows_overhang_slowdown.wxMediaStateconstants by changing out-of-range enumconstexprvalues toinline const.Scope
This is a minimal regression fix. It does not redesign the Fuzzy Skin/overhang-speed pipeline.
Global Fuzzy Skin modes such as
External,All, andAllWallskeep the existing behavior where percentage-based overhang-degree detection is disabled. A broader fix for global Fuzzy Skin would likely require detecting/assigning overhang slowdown before applying Fuzzy Skin geometry, then preserving that speed metadata through fuzzy path generation.Validation
v02.05.00.66.FuzzySkinType::NonemeansNone(allow paint).fuzzy_skin_allows_overhang_slowdown.Build completed successfully on macOS Apple Silicon with Xcode 26.
Notes
This does not change Fuzzy Skin geometry generation, configured overhang speed values, H2D nozzle logic, or process-profile logic.
No automated regression test was added because the affected helper is file-local and a meaningful test would require an integration slicing scenario with modifier/painted Fuzzy Skin and generated overhang-speed inspection.