Fix macOS 26+ dock icon losing system theming (#8816)#11577
Open
d3ns0n wants to merge 1 commit into
Open
Conversation
On macOS 26 (Tahoe) the runtime dock icon override suppressed the system's Liquid Glass / tinted icon theming. Skip setting a custom dock icon on macOS 26 and later so the themed bundle icon is used. Add is_mac_os_at_least() using NSProcessInfo so the check is a lower bound (covers 27+) and works regardless of the build SDK. Fixes bambulab#8816
Author
Haidiye00
removed their request for review
July 17, 2026 01:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Problem
On macOS 26 (Tahoe) the Bambu Studio dock icon does not respect the system's
new icon theming (Liquid Glass / Tinted / Clear / Dark). When the app launches
it loses the themed appearance and shows a plain raster icon instead.
Root cause: on startup
MainFramesets a custom dock icon at runtime via awxTBI_DOCKtaskbar icon (BambuStudio-mac_256px.ico). This calls-[NSApp setApplicationIconImage:]under the hood, which overrides the systemtheming that macOS applies to the app bundle icon (
Icon.icns).Fixes #8816
Change
Skip the runtime dock-icon override on macOS 26 and later, so the system-themed
bundle icon is used instead. Behaviour on macOS < 26 is unchanged.
Slic3r::is_mac_os_at_least(int major)inMacUtils.mm, implemented with-[NSProcessInfo isOperatingSystemAtLeastVersion:]. This is a lower-boundcheck, so future releases (27+) are covered automatically, and it works
regardless of the SDK the project is built with.
#ifdef __APPLE__dock-icon initialization inMainFramewithif (!is_mac_os_at_least(26)).Testing
(verified with the "Tinted" style — the running app's dock icon stays tinted
instead of reverting to the raster icon).
#ifdef __APPLE__, so non-Apple builds areunaffected.