ref: Replace hardcoded booleans with named macros#223
Merged
Conversation
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
2 times, most recently
from
ab02e52 to
c0aaec7
Compare
Member
|
@DavidMCerdeira looks good so far. Please let me know when its ready for final review |
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
from
c0aaec7 to
acf3c60
Compare
DavidMCerdeira
requested review from
AfonsoSantos96,
josecm and
ninolomata
as code owners
Member
Author
|
@josecm this is ready for review |
danielRep
approved these changes
Aug 6, 2025
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
from
acf3c60 to
8784329
Compare
josecm
requested changes
Nov 6, 2025
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
from
8784329 to
a2fd77c
Compare
josecm
requested review from
joaopeixoto13,
malejo97 and
sandro2pinto
as code owners
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
from
a2fd77c to
254c0e8
Compare
danielRep
requested changes
Nov 20, 2025
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
from
254c0e8 to
41685d2
Compare
This commit updates mainly memory and bitmap operations to use named macros like MEM_FREE_PAGES, MEM_ALIGNED_REQ, and BITMAP_SET instead of raw boolean values. Signed-off-by: David Cerdeira <davidmcerdeira@gmail.com>
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
from
41685d2 to
711cabb
Compare
danielRep
approved these changes
Nov 20, 2025
josecm
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates mainly memory and bitmap operations to use named macros like MEM_DONT_FREE_PAGES, MEM_ALIGN_PPAGES, and BITMAP_DONT_SET instead of raw boolean values on respective functions.