Skip to content

Fix RH850 vIPIR emulation#362

Merged
DavidMCerdeira merged 1 commit into
mainfrom
fix/rh850-vipir-emulation
May 15, 2026
Merged

Fix RH850 vIPIR emulation#362
DavidMCerdeira merged 1 commit into
mainfrom
fix/rh850-vipir-emulation

Conversation

@malejo97
Copy link
Copy Markdown
Contributor

The previous vIPIR emulation handler had a few issues:

  • Bitwise instructions were incorrectly treated as a subset of read/write instructions.
  • pCPU↔vCPU mask translation was using the number of CPUs in the current VM instead of the number of CPUs in the platform.
  • Read operations were incorrectly translating masks back to pCPU masks instead of returning vCPU masks.

This PR fixes these issues and updates acc->arch.bit to store the actual bit mask associated with the bitwise instruction, rather than the bit index.

⚠️ Depends on #361

@malejo97 malejo97 changed the title Fix/rh850 vipir emulation Fix RH850 vIPIR emulation May 14, 2026
@malejo97 malejo97 force-pushed the fix/rh850-vipir-emulation branch from 67fa6db to 4a4d780 Compare May 15, 2026 14:31
DavidMCerdeira
DavidMCerdeira previously approved these changes May 15, 2026
@danielRep
Copy link
Copy Markdown
Member

Can you rebase this @malejo97 ?

@malejo97
Copy link
Copy Markdown
Contributor Author

Can you rebase this @malejo97 ?

Done @danielRep

Signed-off-by: Manuel Rodríguez <manuel.cederog@gmail.com>
@malejo97 malejo97 force-pushed the fix/rh850-vipir-emulation branch from 9f46fe6 to c2e79c9 Compare May 15, 2026 15:28
@DavidMCerdeira DavidMCerdeira merged commit 9a30fd8 into main May 15, 2026
45 checks passed
@DavidMCerdeira DavidMCerdeira deleted the fix/rh850-vipir-emulation branch May 15, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants