chore: upgrade wasmtime v28 to v43, switch CI to cargo-deny#66
Merged
Conversation
Upgrade wasmtime from 28.0.1 to 43.0.1, resolving 18 security advisories (16 wasmtime vulnerabilities + 3 unmaintained transitive deps that are no longer pulled in). Code changes: - ResourceLimiter trait: return type changed from anyhow::Result<bool> to Result<bool, wasmtime::Error> (instance.rs, limits.rs) - Remove deprecated Config::async_support(false) call (engine.rs) - Drop unused "async" feature flag from wasmtime dependency CI changes: - Replace cargo-audit with cargo-deny for advisory checking - Remove continue-on-error — audit now blocks on real issues - Add deny.toml with ignore list for 2 remaining advisories: - RUSTSEC-2025-0134: rustls-pemfile unmaintained (transitive, no upgrade) - RUSTSEC-2026-0049: rustls-webpki CRL bug (pinned by async-nats) - Remove obsolete .cargo/audit.toml All 506 workspace tests pass. Zero clippy warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-audit(withcontinue-on-error: true) tocargo deny check advisories— audit now blocks on real issuesdeny.tomlwith ignore list for 2 remaining advisories (rustls-pemfile unmaintained, rustls-webpki CRL bug pinned by async-nats).cargo/audit.tomlOnly 3 lines of code changed (ResourceLimiter return type + deprecated config removal). The wasmtime API was remarkably stable across 15 major versions.
Test plan
cargo fmt --all— cleancargo clippy --lib --bins— zero warningscargo test --workspace— 506 tests pass, 0 failurescargo deny check advisories— passes (2 ignored, down from 20)