feat(device): add Sculpfun C1 engraver#249
Merged
Merged
Conversation
Contributor
|
Awesome, Thanks for the PR! Perhaps setting a frame and focus power makes sense? |
Contributor
Author
|
That's good on my side :) |
Contributor
Author
|
The only nit-pick is the max cut speed. Being a 3w laser, even if the theoric value is 10,000; in reality it would be 400 or something like that. I guess this is OK to keep the theoric value. I never used it to cut, so maybe someone later could improve the value, if needed. |
Contributor
|
Sounds good. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
A patch to add the Scupfun C1 engraver to the list of known devices (this is this one: https://www.sculpfun.com/collections/laser-engraver/products/sculpfun-c1-mini-laser-engraver-3w).
I duplicated the
sculpfun-s30file structure, and filed with what the software found when I added the machine manually (by copying only the relevant data saved in~/.var/app/org.rayforge.rayforge/config/rayforge/dialects+~/.var/app/org.rayforge.rayforge/config/rayforge/machines).