update agy desktop and agy cli items - #15
Conversation
|
Looks good, merging. One follow-up: renaming lines from Gemini Pro/Flash/Claude → Session/Weekly/… may break existing trayLines / Modern pins for people who customized them. A small migration mapping old → new labels would help. Not blocking. |
Thanks for reviewing, yea just fyi gemini pro/flash/claude is the legacy usage display, and it's been replaced with session/weekly. |
Thanks for the context, Session/Weekly makes sense. Feel free to add the migration here or in a follow-up; I’ll take another look once you push updates. I’ll merge when CI is green and the changes still look good. |
|
I'll merge the current commit within 2 days unless you push updates to this branch. Tray label migration can land in a follow-up PR. |
|
Thanks for the migration looks good overall, and CI is green. Before merge: ANTIGRAVITY_PLUGIN_IDS includes antigravity-ide, but that plugin still uses Gemini Pro / Flash / Claude. Migrating those tray lines to Session / Weekly would break IDE customizations. Please drop antigravity-ide from the set (keep only antigravity + antigravity-cli). Also prefer in this PR (Windows CLI): in read_windows_keyring_password, for the go-keyring target (service:username), after get_secret + UTF-8 decode fails, fall back to get_password() on that same entry before trying the default username.service target. Why: agy writes raw UTF-8 (get_secret works), but antigravity-cli token refresh writes via set_password (UTF-16). Without the fallback, the next probe can fail to read the credential we just wrote. Optional nits: map "Claude Weekly" → "Weekly — Claude and GPT Models", plus a small settings test for the migration. Happy to merge once the antigravity-ide fix is in; the keyring fallback would be great in the same commit if you have time. |
yea mb got the wrong migration lol, I'll add your review items later |
|
Thanks again for the migration/color fix in 1ae663f that part looks good. I’m going to ship 1.3.2 from #16 (OpenUsage port) without waiting on this PR, so #15 will target the next release (likely 1.3.3), not 1.3.2. Still happy to merge this once the Windows go-keyring fallback is in (get_password on the same service:username entry when UTF-8 get_secret fails). No deadline push when you can and I’ll review. |
|
Hi the Windows go-keyring is actually in place, sry forgot to split into a different commit, should be safe to merge! |
|
Thanks confirmed the Windows go-keyring fix is in place (get_secret + UTF-8 decode for go-keyring targets). That’s what we needed. The merge conflicts aren’t from your logic fighting ours the branch is based before #16 and #17 landed on feat/linux-windows-native-support (1.3.2 + 1.3.3), so GitHub can’t auto-merge. Since maintainer edits are enabled, I’ll rebase/resolve conflicts on my side and merge for the next patch (likely 1.3.4). No action needed from you unless I ping with a question. Appreciate the work on agy desktop/cli + the migration bits. |
1ae663f to
0a99392
Compare
thanks for your work too, been looking for this app on windows! |
4029c9f
into
barramee27:feat/linux-windows-native-support
Description
fix agy desktop and agy cli token retrieval on windows
update agy endpoint
update usage display items
Related Issue
Type of Change
Testing
bun run buildand it succeededbun run testand all tests passbun tauri devScreenshots
Checklist
mainbranch