You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perform a final holistic review of stacked layout before closing the tracker, after the implementation, docs, and verification issues have landed.
This is a review/refinement issue, not a feature expansion issue.
Scope
Re-read the final vimdoc for ++layout=stacked and confirm the public wording is accurate, concise, and consistent with existing help style.
Specifically review the helpdoc phrasing for:
:Gdiff and :Greview signatures and parameter descriptions;
side-aware line-number semantics;
the ASCII example around replacements;
highlight group wording for dual and single rails.
Review the final code shape across the stacked-layout PR series for small architecture cleanups that are easier to see after the full feature exists.
Look for unnecessary duplication, awkward naming, over-scoped helpers, missing ownership boundaries, or stale comments/types introduced during the series.
Confirm the final implementation still matches Tracker: stacked generated diff layout #358’s accepted non-goals: no public config, no split-layout behavior changes, and no rewrite of generated hunk metadata.
Non-goals
Do not add new stacked-layout behavior unless it is needed to fix a bug found during review.
Do not rename public user-facing options after docs have landed unless the tracker owner explicitly approves it.
Do not perform broad unrelated refactors.
Acceptance criteria
Helpdoc language is reviewed and adjusted if necessary.
Any small stacked-layout code cleanups are made, or explicitly deemed unnecessary.
Part of #358.
Goal
Perform a final holistic review of stacked layout before closing the tracker, after the implementation, docs, and verification issues have landed.
This is a review/refinement issue, not a feature expansion issue.
Scope
++layout=stackedand confirm the public wording is accurate, concise, and consistent with existing help style.:Gdiffand:Greviewsignatures and parameter descriptions;Non-goals
Acceptance criteria
Verification