Skip to content

bug: Diff review doesn't skip binary files #416

Description

@SevereOverfl0w

Prerequisites

Neovim version

NVIM v0.13.0-dev-726+ga69f2db773-Homebrew

Operating system

MacOS

Description

Pressing ]f gave me an error message: diff does not support binary files. I would hope to either skip the binary files OR do something sensible (show me "--binary" in a buffer or whatever git does).

In any case, I couldn't skip the binary file to continue my review, not even with 2]f to jump over it or similar.

Steps to reproduce

  1. Modify a text file a and a binary file b and commit it
  2. Diff review ++layout=split HEAD^
  3. ]f

Health check

==============================================================================
diffs:                                                                      ✅

diffs.nvim ~
- ✅ OK Neovim 0.9.0+ detected
- ✅ OK vim-fugitive detected
- libvscode_diff not found (optional, using native vim.diff fallback)
- difftastic not enabled (optional, set integrations.difftastic

Minimal reproduction

it did reproduce with this config.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions