fix(review): label skipped files in review surfaces#418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Review file lists can still present unsupported files as if they are normal split-review targets. That makes quickfix rows, the split-review picker, and explicit selection paths less clear after sequential navigation has learned to skip unsupported entries.
Solution
Carry skipped-file metadata through generated review file entries, quickfix rows, split-review selections, and the public review file API. Render skipped entries as
(skipped)in review file list surfaces while keeping line stats aligned after the marked filename, and make skipped direct selections log the concise skipped-file message without switching files.