Skip to content

Commit a71ba9f

Browse files
updated slack notifier bot start tracking command output
1 parent ee9a841 commit a71ba9f

2 files changed

Lines changed: 15 additions & 13 deletions

File tree

packages/notifier-bot/convex/slack.commands.test.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ describe('Slack multi-channel subscriptions', () => {
182182
).toBe(true);
183183

184184
expect(responseMessages).toEqual([
185-
'Already tracking `react` — currently at `19.0.0` in *#frontend* [minor+]',
185+
'Already tracking *<https://www.npmjs.com/package/react|react>* — currently at `19.0.0` in *#frontend* [minor+]',
186186
]);
187187
});
188188

@@ -217,7 +217,9 @@ describe('Slack multi-channel subscriptions', () => {
217217
);
218218
expect(subscriptions).toHaveLength(1);
219219
expect(subscriptions[0].minUpdateType).toBe('major');
220-
expect(responseMessages[0]).toContain('Updated: now tracking `react`');
220+
expect(responseMessages[0]).toContain(
221+
'Updated: now tracking *<https://www.npmjs.com/package/react|react>*',
222+
);
221223
expect(responseMessages[0]).toContain('[major only]');
222224
});
223225

@@ -377,13 +379,13 @@ describe('Slack multi-channel subscriptions', () => {
377379
'<@U_ALICE> processed *3* package requests in this channel:',
378380
);
379381
expect(postedMessages[0].text).toContain(
380-
'• `tsx` — current version `4.21.0`',
382+
'• *<https://www.npmjs.com/package/tsx|tsx>* — current version `4.21.0`',
381383
);
382384
expect(postedMessages[0].text).toContain(
383-
'• `oxlint` — current version `1.59.0`',
385+
'• *<https://www.npmjs.com/package/oxlint|oxlint>* — current version `1.59.0`',
384386
);
385387
expect(postedMessages[0].text).toContain(
386-
'• `vitest` — current version `4.1.4`',
388+
'• *<https://www.npmjs.com/package/vitest|vitest>* — current version `4.1.4`',
387389
);
388390
expect(responseMessages).toEqual([]);
389391
});
@@ -425,7 +427,7 @@ describe('Slack multi-channel subscriptions', () => {
425427
expect(postedMessages).toHaveLength(1);
426428
expect(postedMessages[0].channel).toBe('C_RELEASES');
427429
expect(postedMessages[0].text).toContain(
428-
'is now tracking `pnpm` in this channel',
430+
'is now tracking *<https://www.npmjs.com/package/pnpm|pnpm>* in this channel',
429431
);
430432
expect(responseMessages).toEqual([]);
431433
});

packages/notifier-bot/convex/slack/commands.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,11 @@ async function trackPackage(
162162
function formatTrackOutcomeLine(outcome: TrackOutcome): string {
163163
switch (outcome.kind) {
164164
case 'tracked':
165-
return `• ${formatPackageName(outcome.packageName)} — current version ${formatVersion(outcome.displayVersion)}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}${outcome.pendingUpdate ? ` (update available: ${formatVersion(outcome.version)})` : ''}`;
165+
return `• ${formatSlackPackageLink(outcome.packageName)} — current version ${formatVersion(outcome.displayVersion)}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}${outcome.pendingUpdate ? ` (update available: ${formatVersion(outcome.version)})` : ''}`;
166166
case 'updated':
167-
return `• ${formatPackageName(outcome.packageName)} — updated threshold to ${outcome.filterLabel ?? 'all'} notifications, current version ${formatVersion(outcome.version)}`;
167+
return `• ${formatSlackPackageLink(outcome.packageName)} — updated threshold to ${outcome.filterLabel ?? 'all'} notifications, current version ${formatVersion(outcome.version)}`;
168168
case 'already':
169-
return `• ${formatPackageName(outcome.packageName)} — already tracked at ${formatVersion(outcome.version)}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}`;
169+
return `• ${formatSlackPackageLink(outcome.packageName)} — already tracked at ${formatVersion(outcome.version)}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}`;
170170
case 'not_found':
171171
return `• ${formatPackageName(outcome.packageName)} — not found on npm`;
172172
}
@@ -593,7 +593,7 @@ export const processNpmTrack = internalAction({
593593
const channelLabel = formatChannelPhrase(outcome.channelName);
594594
await sendFeedback(
595595
details,
596-
`Updated: now tracking ${formatPackageName(packageName)}${channelLabel} with ${outcome.filterLabel ?? 'all'} notifications — currently at ${formatVersion(outcome.version)}`,
596+
`Updated: now tracking ${formatSlackPackageLink(packageName)}${channelLabel} with ${outcome.filterLabel ?? 'all'} notifications — currently at ${formatVersion(outcome.version)}`,
597597
);
598598
if (!responseUrl && userId) {
599599
await ctx.scheduler.runAfter(
@@ -609,7 +609,7 @@ export const processNpmTrack = internalAction({
609609
const channelLabel = formatChannelPhrase(outcome.channelName);
610610
await sendFeedback(
611611
details,
612-
`Already tracking ${formatPackageName(packageName)} — currently at ${formatVersion(outcome.version)}${channelLabel}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}`,
612+
`Already tracking ${formatSlackPackageLink(packageName)} — currently at ${formatVersion(outcome.version)}${channelLabel}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}`,
613613
);
614614
if (!responseUrl && userId) {
615615
await ctx.scheduler.runAfter(
@@ -632,7 +632,7 @@ export const processNpmTrack = internalAction({
632632
await chatPostMessage(
633633
details.accessToken,
634634
channelId,
635-
`<@${userId}> is now tracking ${formatPackageName(packageName)} in this channel — current version ${formatVersion(outcome.displayVersion)}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}${updateSuffix}`,
635+
`<@${userId}> is now tracking ${formatSlackPackageLink(packageName)} in this channel — current version ${formatVersion(outcome.displayVersion)}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}${updateSuffix}`,
636636
);
637637
} catch (error) {
638638
if (error instanceof PrivateChannelError) {
@@ -654,7 +654,7 @@ export const processNpmTrack = internalAction({
654654
await chatPostMessage(
655655
details.accessToken,
656656
userId,
657-
`You're now tracking ${formatPackageName(packageName)} — current version ${formatVersion(outcome.displayVersion)}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}.${updateSuffix || " I'll DM you when updates are available."}`,
657+
`You're now tracking ${formatSlackPackageLink(packageName)} — current version ${formatVersion(outcome.displayVersion)}${outcome.filterLabel ? ` ${outcome.filterLabel}` : ''}.${updateSuffix || " I'll DM you when updates are available."}`,
658658
);
659659
}
660660
}

0 commit comments

Comments
 (0)