make kind-dev-cluster path-independent, and remove reserved var warnings (skupperproject#2347)

Fixes skupperproject#2345

Author: AryanP123

scripts/kind-dev-cluster

@@ -39,6 +39,9 @@ FORCE_RECREATE="false"
 METALLB="false"
 SUBNET="1"
 
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
+
 verbose_log() {
 	if [ "${VERBOSE}" == "true" ]; then
 		echo "(skdev) $1"
@@ -175,7 +178,7 @@ EOF
 }
 
 skupper::cluster::controller() {
-	SKUPPER_TESTING=true scripts/skupper-deployment-generator.sh cluster ${IMAGE_TAG} ${ROUTER_IMAGE_TAG} false
+	SKUPPER_TESTING=true "${REPO_ROOT}/scripts/skupper-deployment-generator.sh" cluster ${IMAGE_TAG} ${ROUTER_IMAGE_TAG} false
 }
 
 main () {

scripts/skupper-deployment-generator.sh

@@ -29,6 +29,9 @@ readonly SKUPPER_TESTING=${SKUPPER_TESTING:-false}
 
 DEBUG=${DEBUG:=false}
 
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
+
 skupper::deployment::namespace() {
 		cat << EOF
 apiVersion: v1
@@ -276,7 +279,7 @@ EOF
 }
 
 main () {
-	ktempdir=$(mktemp -d --tmpdir=./)
+	ktempdir=$(mktemp -d --tmpdir="${REPO_ROOT}")
 	if [ "${DEBUG}" != "true" ]; then
 		trap 'rm -rf $ktempdir' EXIT
 	fi

tests/e2e/collections/ansible_collections/e2e/tests/roles/generate_namespaces/tasks/main.yml

@@ -11,8 +11,8 @@
         labels:
           e2e.id: "{{ generate_namespaces_namespace_label }}"
     kubeconfig: "{{ kubeconfig }}"
-  register: namespace
+  register: namespace_result
 
 - name: Display namespace name
   ansible.builtin.debug:
-    msg: "Namespace Name: {{ namespace.result.metadata.labels['kubernetes.io/metadata.name'] }}"
+    msg: "Namespace Name: {{ namespace_result.result.metadata.labels['kubernetes.io/metadata.name'] }}"

tests/e2e/collections/ansible_collections/e2e/tests/roles/run_curl/tasks/main.yml

@@ -1,14 +1,14 @@
 ---
 - name: Setting namespace name with prefix
   ansible.builtin.set_fact:
-    namespace: "{{ namespace_prefix }}-{{ namespace_name }}"
+    curl_namespace: "{{ namespace_prefix }}-{{ namespace_name }}"
 
 - name: Deploy curl pod
   kubernetes.core.k8s:
     api_version: v1
     kind: Pod
     name: curl
-    namespace: "{{ namespace }}"
+    namespace: "{{ curl_namespace }}"
     kubeconfig: "{{ kubeconfig }}"
     state: present
     definition:
@@ -29,7 +29,7 @@
 
 - name: Run curl command
   kubernetes.core.k8s_exec:
-    namespace: "{{ namespace }}"
+    namespace: "{{ curl_namespace }}"
     kubeconfig: "{{ kubeconfig }}"
     pod: curl
     command: >-