chore: fix sonarcube errors

Author: bartstc

server/src/shared/types.ts

@@ -1,8 +1,10 @@
 import type { User } from "@/modules/auth/auth.types.js";
 import type { Product } from "@/modules/products/products.types.js";
-import type { MarketingProduct } from "@/modules/marketing/marketing.types.js";
+import type {
+  MarketingProduct,
+  Review,
+} from "@/modules/marketing/marketing.types.js";
 import type { Cart } from "@/modules/carts/carts.types.js";
-import type { Review } from "@/modules/marketing/marketing.types.js";
 
 export interface DatabaseSchema {
   users: User[];

src/features/marketing/reviews/components/WriteReviewButton.tsx

@@ -22,11 +22,13 @@ const WriteReviewButton = ({ productId, initialRating }: IProps) => {
 
   if (!isAuthenticated) return null;
 
-  const label = currentUserReview
-    ? currentUserReview.title || currentUserReview.comment
-      ? t("edit-review")
-      : t("add-review-details")
-    : t("write-review");
+  const getLabel = () => {
+    if (!currentUserReview) return t("write-review");
+    if (currentUserReview.title || currentUserReview.comment)
+      return t("edit-review");
+    return t("add-review-details");
+  };
+  const label = getLabel();
 
   return (
     <>

src/features/marketing/reviews/providers/use-create-review-mutation.ts

@@ -13,13 +13,15 @@ export const useCreateReviewMutation = (productId: string) => {
 
   const { mutateAsync, isPending } = useMutation({
     ...createReviewMutationOptions,
-    onSuccess: () => {
-      void queryClient.invalidateQueries({
-        queryKey: marketingQueryKeys.product(productId),
-      });
-      void queryClient.invalidateQueries({
-        queryKey: marketingQueryKeys.reviews(productId),
-      });
+    onSuccess: async () => {
+      await Promise.all([
+        queryClient.invalidateQueries({
+          queryKey: marketingQueryKeys.product(productId),
+        }),
+        queryClient.invalidateQueries({
+          queryKey: marketingQueryKeys.reviews(productId),
+        }),
+      ]);
     },
   });
 

src/features/marketing/reviews/providers/use-update-review-mutation.ts

@@ -11,13 +11,15 @@ export const useUpdateReviewMutation = (productId: string) => {
 
   const { mutateAsync, isPending } = useMutation({
     ...updateReviewMutationOptions,
-    onSuccess: () => {
-      void queryClient.invalidateQueries({
-        queryKey: marketingQueryKeys.product(productId),
-      });
-      void queryClient.invalidateQueries({
-        queryKey: marketingQueryKeys.reviews(productId),
-      });
+    onSuccess: async () => {
+      await Promise.all([
+        queryClient.invalidateQueries({
+          queryKey: marketingQueryKeys.product(productId),
+        }),
+        queryClient.invalidateQueries({
+          queryKey: marketingQueryKeys.reviews(productId),
+        }),
+      ]);
     },
   });