Skip to content

Commit 48c4701

Browse files
committed
chore: apply fixes after lessons
1 parent 766e79f commit 48c4701

4 files changed

Lines changed: 21 additions & 97 deletions

File tree

.agents/skills/executing-plans/SKILL.md

Lines changed: 0 additions & 96 deletions
This file was deleted.

.agents/skills/writing-spec/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Collaborate with the developer to fill sections 1-3 of the template.
3434

3535
Collaborate on sections 4-6 of the template.
3636

37-
1. Propose a **Building Blocks Diff** — list every block that is ADDED, MODIFIED, or DELETED. Use the project's building block taxonomy from `.agents/skills/building-blocks/SKILL.md` (mutation-hook, query-options-factory, store, use-case-hook, pure-component, compound-component, page, facade-hook, frontend-model, value-object, etc.). Reference by **name and type only** — do not define internals. Implementation details belong in coding standards and per-type skills, not specs. For changes that don't map to a typed building block, use the target file path + a short description instead.
37+
1. Propose a **Building Blocks Diff** — list every block that is ADDED, MODIFIED, or DELETED. Use the project's building block taxonomy from `.agents/skills/building-blocks/SKILL.md`. Reference by **name and type only** — do not define internals. Implementation details belong in coding standards and per-type skills, not specs. For changes that don't map to a typed building block, use the target file path + a short description instead.
3838
2. For non-trivial features, propose **two plausible designs** with tradeoffs. Let the developer choose. Capture the winner and rationale in **Design Decisions**
3939
3. Draft the **Boundaries** section using the three-tier system:
4040
-**Always** — proceed without asking (e.g., create files in the feature directory)

docs/architecture.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ Each feature follows feature slice architecture patterns with four layers:
5353
- **components/** - UI components, presentational and decoupled from business logic (application) and router state. Data access is only through `providers/`.
5454
- **application/** - Business logic, portable state management (stores, FSMs, form validation), custom hooks. Should not depend on router state or external APIs directly (only through `providers/`).
5555
- **providers/** - Hook composition and data access gateway for the feature slice. Exposes query hooks, mutations, loaders, domain errors, and DTOs sourced from `src/lib/api/`. Library-specific code (React Query, etc.) must not leak beyond this layer.
56+
- files are named after their primary export or reexport: `useCartProductsQuery``use-cart-products-query.ts`, `useAddToCartMutation``use-add-to-cart-mutation.ts`
5657
- **models/** - Domain type definitions, utilities, and type mapping functions.
5758

5859
**Dependency rule:** `components/` and `application/` import from `models/` and `providers/`. `providers/` and `models/` have no internal feature dependencies.

specs/lessons.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# Lessons Learned
2+
3+
Patterns captured after corrections. Review at session start.
4+
5+
## Template
6+
7+
```markdown
8+
## L<NNN> — <short title>
9+
10+
**Rule:** <the rule to follow going forward>
11+
12+
**Why it failed:** <what caused the mistake>
13+
14+
**How to apply:** <concrete guidance for when/where this kicks in>
15+
16+
**Source:** <context — spec, PR, correction date>
17+
```
18+
19+
---

0 commit comments

Comments
 (0)