Skip to content

Use public images and prep for next release#16

Merged
jackjohn7 merged 16 commits intomainfrom
jack/use-public-images
Aug 25, 2025
Merged

Use public images and prep for next release#16
jackjohn7 merged 16 commits intomainfrom
jack/use-public-images

Conversation

@jackjohn7
Copy link
Copy Markdown
Member

@jackjohn7 jackjohn7 commented Aug 19, 2025

  • Update Dockerfile template to use our images with parameterized tags
  • Update Dockerfile rendering to provide appropriate tags for server and client if necessary
  • Clean up a few things in the execution process in Dockerfile

Close #15

@jackjohn7 jackjohn7 self-assigned this Aug 19, 2025
Copy link
Copy Markdown
Member

@funnyboy-roks funnyboy-roks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few thoughts about potential improvements.

Comment thread Cargo.toml Outdated
Comment thread src/build.rs Outdated
Comment thread tests/event-handlers.js Outdated
Comment thread data/basalt.Dockerfile Outdated
Comment thread Cargo.toml Outdated
jackjohn7 and others added 9 commits August 19, 2025 23:59
funnyboy-roks
funnyboy-roks previously approved these changes Aug 25, 2025
Copy link
Copy Markdown
Member

@funnyboy-roks funnyboy-roks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar issue, but otherwise good with me

Comment thread README.md Outdated
Co-authored-by: Funny <funnyboyroks@gmail.com>
@jackjohn7 jackjohn7 merged commit 5b7dabb into main Aug 25, 2025
12 of 13 checks passed
@jackjohn7 jackjohn7 deleted the jack/use-public-images branch August 25, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support event-hook registration

2 participants