Skip to content

added BaseAccountSDK return type for createBaseAccountSDK.ts for bett… #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aschenkuttel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added BaseAccountSDK return type for createBaseAccountSDK.ts for bett… #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/account-sdk/src/interface/builder/core/createBaseAccountSDK.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,26 @@ export type CreateProviderOptions = Partial<AppMetadata> & {
paymasterUrls?: Record<number, string>;
};

export type BaseAccountSDK = {
getProvider: () => ProviderInterface | null;
subAccount: {
create(accountParam: AddSubAccountAccount): Promise<SubAccount>;
get(): Promise<SubAccount | null>;
addOwner(params: {
address?: `0x${string}`;
publicKey?: `0x${string}`;
chainId: number;
}): Promise<string>;
setToOwnerAccount(toSubAccountOwner: ToOwnerAccountFn): void;
};
};

/**
* Create Base AccountSDK instance with EIP-1193 compliant provider
* @param params - Options to create a base account SDK instance.
* @returns An SDK object with a getProvider method that returns an EIP-1193 compliant provider.
* @returns BaseAccountSDK - An SDK object with a getProvider method that returns an EIP-1193 compliant provider.
*/
export function createBaseAccountSDK(params: CreateProviderOptions) {
export function createBaseAccountSDK(params: CreateProviderOptions): BaseAccountSDK {
const options: ConstructorOptions = {
metadata: {
appName: params.appName || 'App',
Expand Down Expand Up @@ -186,4 +200,4 @@ export function createBaseAccountSDK(params: CreateProviderOptions) {
};

return sdk;
}
}