fix: validate eth_sendTransaction response is a tx hash not a signature#263
Open
ygd58 wants to merge 1 commit intobase:masterfrom
Open
fix: validate eth_sendTransaction response is a tx hash not a signature#263ygd58 wants to merge 1 commit intobase:masterfrom
ygd58 wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
Author
|
hey @fan-zhang-sv @spencerstock can you take a look when you get a chance? |
tezzalee85
approved these changes
Apr 23, 2026
Collaborator
|
Review Error for tezzalee85 @ 2026-04-23 20:18:19 UTC |
Author
|
hey @fan-zhang-sv this has an approval now but it needs one from someone with write access. can you take a look? |
ygd58
force-pushed
the
fix/eth-sendtransaction-validate-tx-hash
branch
from
e4681c0 to
17e2bba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was testing eth sendTransaction through the wagmi baseAccount connector and noticed it returns a 65 byte ECDSA signature instead of a transaction hash. Added a check to validate the response is actually a transaction hash before returning it so callers get a proper error instead of silently working with a wrong value.