fix(spend-permission): throw instead of console.warn in createSpendPermissionTypedDataWithSeconds production guard#327
Open
Nexory wants to merge 2 commits into
Conversation
…rmissionTypedDataWithSeconds production guard The function is marked @testonly but the production guard previously emitted only a console.warn before returning valid typed data. In a bundled production build the warning is typically suppressed or unobserved, so a caller who accidentally imports this helper still receives the typed data and can submit a spend permission with raw seconds (instead of days) as the period unit. This patch throws instead, so the guard actually prevents misuse. Closes base#325
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #325
@testonly function should throw in production, not console.warn — Issue #325
The diff is a 1-line behavioral fix. See Issue #325 for the full rationale.