fix(sendUserOpAndWait): preserve userOpHash on wait timeout#354
Open
Sertug17 wants to merge 1 commit into
Open
fix(sendUserOpAndWait): preserve userOpHash on wait timeout#354Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
When waitForUserOperation times out, the error message currently swallows the userOpHash and gives no indication that the user operation was already broadcast. Attach userOpHash and a broadcast: true flag to the thrown error so callers can distinguish between the op never reaching the mempool and the op being broadcast but confirmation taking longer than the timeout. This prevents a false-negative where a caller thinks the revoke/ charge failed when it was actually submitted and may confirm shortly.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When waitForUserOperation times out, the error currently swallows the userOpHash and gives no indication the operation was already broadcast. Attach userOpHash and broadcast: true to the thrown error so callers can distinguish between broadcast failure and confirmation timeout.