Skip to content

Commit 2e348fa

Browse files
PelleKrabclaude
andcommitted
refactor(L1): reorder IProtocolVersions members to match style guide
Events before errors, and mutating externals before view getters, mirroring the ProtocolVersions contract body and the repo style-guide ordering. ABI is generator-sorted, so no snapshot or semver-lock impact. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 21e6cc7 commit 2e348fa

1 file changed

Lines changed: 14 additions & 16 deletions

File tree

interfaces/L1/IProtocolVersions.sol

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@ import { IReinitializableBase } from "interfaces/universal/IReinitializableBase.
88
/// @title IProtocolVersions
99
/// @notice Interface for the ProtocolVersions upgrade schedule contract.
1010
interface IProtocolVersions is IProxyAdminOwnedBase, ISemver, IReinitializableBase {
11+
event UpgradeRegistered(uint256 indexed id);
12+
event MinimumProtocolVersionUpdated(uint256 indexed protocolVersion);
13+
event TimestampSet(uint256 indexed id, uint256 timestamp);
14+
event ScheduleIdUpdated(bytes32 indexed newScheduleId);
15+
event IncidentResponderUpdated(address indexed previousIncidentResponder, address indexed newIncidentResponder);
16+
event Initialized(uint8 version);
17+
1118
error ProtocolVersions_UnknownUpgrade(uint256 id);
1219
error ProtocolVersions_InvalidProtocolVersion();
1320
error ProtocolVersions_ActivationAlreadyPassed(uint256 id, uint64 activationTimestamp);
@@ -17,28 +24,19 @@ interface IProtocolVersions is IProxyAdminOwnedBase, ISemver, IReinitializableBa
1724
error ProtocolVersions_NotInitialized();
1825
error ProtocolVersions_InsufficientNotice(uint64 timestamp);
1926

20-
event UpgradeRegistered(uint256 indexed id);
21-
event MinimumProtocolVersionUpdated(uint256 indexed protocolVersion);
22-
event TimestampSet(uint256 indexed id, uint256 timestamp);
23-
event ScheduleIdUpdated(bytes32 indexed newScheduleId);
24-
event IncidentResponderUpdated(address indexed previousIncidentResponder, address indexed newIncidentResponder);
25-
event Initialized(uint8 version);
26-
27-
function MIN_NOTICE() external view returns (uint64);
28-
29-
function incidentResponder() external view returns (address);
30-
function scheduleId() external view returns (bytes32);
31-
function scheduleId(uint256 id) external view returns (bytes32);
32-
function minimumProtocolVersion() external view returns (uint256);
33-
34-
function getSchedule() external view returns (uint64[] memory);
35-
3627
function initialize(address _incidentResponder) external;
3728
function registerUpgrade(uint64 timestamp, uint256 minProtocolVersion) external returns (uint256);
3829
function setMinimumProtocolVersion(uint256 protocolVersion) external;
3930
function setTimestamp(uint256 id, uint64 timestamp) external;
4031
function setIncidentResponder(address newIncidentResponder) external;
4132
function delayTimestamp(uint256 id, uint64 newTimestamp) external;
4233

34+
function MIN_NOTICE() external view returns (uint64);
35+
function minimumProtocolVersion() external view returns (uint256);
36+
function incidentResponder() external view returns (address);
37+
function scheduleId() external view returns (bytes32);
38+
function scheduleId(uint256 id) external view returns (bytes32);
39+
function getSchedule() external view returns (uint64[] memory);
40+
4341
function __constructor__() external;
4442
}

0 commit comments

Comments
 (0)