Skip to content

Commit 69bf0f1

Browse files
authored
remove todos (#1634)
1 parent b992d83 commit 69bf0f1

2 files changed

Lines changed: 0 additions & 18 deletions

File tree

docs/base-chain/specs/protocol/consensus/p2p.mdx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,6 @@ Peers may be banned if their performance score is too low, or if an objectively
111111

112112
Banned peers will be persisted to the same data-store as the peerstore records.
113113

114-
TODO: the connection gater does currently not gate by IP address on the dial Accept-callback.
115-
116114
#### Transport security
117115

118116
[Libp2p-noise][libp2p-noise], `XX` handshake, with the `secp256k1` P2P identity, as popularized in Eth2.
@@ -322,8 +320,6 @@ the safe head will be based on whatever the batcher's source's unsafe head is.
322320

323321
#### Block topic scoring parameters
324322

325-
TODO: GossipSub per-topic scoring to fine-tune incentives for ideal propagation delay and bandwidth usage.
326-
327323
## Req-Resp
328324

329325
The consensus client (`base-consensus`) implements a similar request-response encoding for its sync protocols as the L1 ethereum Beacon-Chain.

docs/base-chain/specs/reference/glossary.mdx

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,6 @@ cf. [Deposits Specification][deposits-spec]
292292

293293
## Withdrawals
294294

295-
> **TODO** expand this whole section to be clearer
296-
297295
[withdrawals]: glossary#withdrawals
298296

299297
In general, a withdrawal is a transaction sent from L2 to L1 that may transfer data and/or value.
@@ -321,8 +319,6 @@ must elapse before a [withdrawal][withdrawals] can be finalized.
321319
The finalization period is necessary to afford sufficient time for [validators][validator] to make a [fault
322320
proof][fault-proof].
323321

324-
> **TODO** specify current value for finalization period
325-
326322

327323
## Configuration
328324

@@ -507,9 +503,6 @@ A batcher is a software component (independent program) that is responsible to m
507503
availability provider. The batcher communicates with the rollup node in order to retrieve the channels. The channels are
508504
then made available using [batcher transactions][batcher-transaction].
509505

510-
> **TODO** In the future, we might want to make the batcher responsible for constructing the channels, letting it only
511-
> query the rollup node for L2 block inputs.
512-
513506
### Batcher Transaction
514507

515508
[batcher-transaction]: glossary#batcher-transaction
@@ -560,8 +553,6 @@ The purpose of channel timeouts is dual:
560553

561554
[reset-channel-buffer]: ../protocol/consensus/derivation#resetting-channel-buffering
562555

563-
> **TODO** specify `CHANNEL_TIMEOUT`
564-
565556

566557
## L2 Output Root Proposals
567558

@@ -746,8 +737,6 @@ behavior.
746737

747738
A rollup node running in validator mode is sometimes called _a replica_.
748739

749-
> **TODO** expand this to include output root submission
750-
751740
See the [rollup node specification][rollup-node-spec] for more information.
752741

753742
### Rollup Driver
@@ -757,9 +746,6 @@ See the [rollup node specification][rollup-node-spec] for more information.
757746
The rollup driver is the [rollup node][rollup-node] component responsible for [deriving the L2 chain][derivation]
758747
from the L1 chain (L1 [blocks][block] and their associated [receipts][receipt]).
759748

760-
> **TODO** delete this entry, alongside its reference — can be replaced by "derivation process" or "derivation logic"
761-
> where needed
762-
763749
### L1 Attributes Predeployed Contract
764750

765751
[l1-attr-predeploy]: glossary#l1-attributes-predeployed-contract

0 commit comments

Comments
 (0)