Skip to content

fix(docs): replace broken appLogoUrl example URL (404) with working URL in 6 SDK files#1388

Open
schoolkamsergj wants to merge 1 commit intobase:masterfrom
schoolkamsergj:fix/broken-app-logo-url-in-sdk-examples
Open

fix(docs): replace broken appLogoUrl example URL (404) with working URL in 6 SDK files#1388
schoolkamsergj wants to merge 1 commit intobase:masterfrom
schoolkamsergj:fix/broken-app-logo-url-in-sdk-examples

Conversation

@schoolkamsergj
Copy link
Copy Markdown

Problem

The example appLogoUrl value https://base.org/logo.png used across 6 SDK documentation files returns 404.

Verification:

curl -sI https://base.org/logo.png
→ HTTP/2 302 → https://www.base.org/logo.png
→ HTTP/2 404

Developers copying these examples see a broken logo in the Base Account SDK popup.

Fix

Replaced the broken URL with the official Base GitHub organization avatar https://avatars.githubusercontent.com/u/108554348?s=200&v=4 which returns HTTP 200 and is stable.

Files changed (6)

  • docs/base-account/improve-ux/sponsor-gas/paymasters.mdx
  • docs/base-account/improve-ux/batch-transactions.mdx
  • docs/base-account/improve-ux/spend-permissions.mdx
  • docs/base-account/improve-ux/sub-accounts.mdx
  • docs/base-account/quickstart/web.mdx
  • docs/base-account/quickstart/web-react.mdx

Closes #1316

…K files

The example URL https://base.org/logo.png returns 404, causing a broken
logo in the Base Account SDK popup for developers copying the examples.

Replaced with the official Base GitHub organization avatar URL which
returns HTTP 200 and is stable.

Affected files (6):
- docs/base-account/improve-ux/sponsor-gas/paymasters.mdx
- docs/base-account/improve-ux/batch-transactions.mdx
- docs/base-account/improve-ux/spend-permissions.mdx
- docs/base-account/improve-ux/sub-accounts.mdx
- docs/base-account/quickstart/web.mdx
- docs/base-account/quickstart/web-react.mdx

Closes base#1316
@cb-heimdall
Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(docs): broken appLogoUrl example URL returns 404 in multiple SDK code examples

2 participants