fix(docs): replace broken appLogoUrl example URL (404) with working URL in 6 SDK files#1388
Open
schoolkamsergj wants to merge 1 commit intobase:masterfrom
Open
Conversation
…K files The example URL https://base.org/logo.png returns 404, causing a broken logo in the Base Account SDK popup for developers copying the examples. Replaced with the official Base GitHub organization avatar URL which returns HTTP 200 and is stable. Affected files (6): - docs/base-account/improve-ux/sponsor-gas/paymasters.mdx - docs/base-account/improve-ux/batch-transactions.mdx - docs/base-account/improve-ux/spend-permissions.mdx - docs/base-account/improve-ux/sub-accounts.mdx - docs/base-account/quickstart/web.mdx - docs/base-account/quickstart/web-react.mdx Closes base#1316
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The example
appLogoUrlvaluehttps://base.org/logo.pngused across 6 SDK documentation files returns 404.Verification:
Developers copying these examples see a broken logo in the Base Account SDK popup.
Fix
Replaced the broken URL with the official Base GitHub organization avatar
https://avatars.githubusercontent.com/u/108554348?s=200&v=4which returns HTTP 200 and is stable.Files changed (6)
docs/base-account/improve-ux/sponsor-gas/paymasters.mdxdocs/base-account/improve-ux/batch-transactions.mdxdocs/base-account/improve-ux/spend-permissions.mdxdocs/base-account/improve-ux/sub-accounts.mdxdocs/base-account/quickstart/web.mdxdocs/base-account/quickstart/web-react.mdxCloses #1316