replace Math.random() nonce with crypto.randomUUID() in Wagmi integration example#1391
Open
weirdDevelop wants to merge 2 commits intobase:masterfrom
Open
replace Math.random() nonce with crypto.randomUUID() in Wagmi integration example#1391weirdDevelop wants to merge 2 commits intobase:masterfrom
weirdDevelop wants to merge 2 commits intobase:masterfrom
Conversation
added 2 commits
May 4, 2026 14:26
…builder-codes Fixes base#1313 - The JSON response example had a trailing comma which is invalid JSON syntax.
Math.random() is not cryptographically secure and should not be used for SIWE nonces. Replaces with window.crypto.randomUUID() to match the approach already used in the authenticate-users guide. Fixes base#1390
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1390
The Wagmi integration setup guide uses Math.random() to generate a SIWE nonce. This is not cryptographically secure — Math.random() values can be predicted and should never be used for security-sensitive parameters.
This replaces it with window.crypto.randomUUID().replace(/-/g, ''), which is already the recommended approach in the authenticate-users guide — this brings the Wagmi integration into alignment.