feat: emit msg.sender in cert revocation events (I-02)#47
Open
leanthebean wants to merge 1 commit into
Open
Conversation
Address BLOCKSEC-5249 finding I-02. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc finding — I-02 (Informational): Missing
msg.senderin Cert Revoked/Unrevoked eventsFrom the BLOCKSEC-5249: Nitro Validator post-Fusaka review audit (finding I-02):
The fix
Add the acting account as a second indexed topic on both revocation events:
and record
msg.senderat every emit site:unrevokeCert→emit CertUnrevoked(certId, msg.sender)_revokeCert→emit CertRevoked(certId, msg.sender)(reached via the external, access-gatedrevokeCert/revokeCerts, somsg.senderis the original caller — the owner for root halts or the delegated revoker for non-root certs)CertVerifiedis intentionally left unchanged — the finding scopes to the revocation events only. No interface change is required; these events are declared inCertManager, not inICertManager.Tests
New
CertRevocationEventTest:test_RevokeCertEmitsSender/test_RevokeCertsEmitsSender/test_UnrevokeCertEmitsSender— assert the event carries the caller viavm.expectEmit.test_RevokeCertRecordsActualCaller— sets a distinct delegated revoker, pranks as it, and asserts that address (not the contract) lands in the topic.forge fmt+ fullforge test: 152 passed, 0 failed, 1 skipped.