fix: align variable validation with usage in nethermind-entrypoint#556
Closed
sky-coderay wants to merge 1 commit intobase:mainfrom
Closed
fix: align variable validation with usage in nethermind-entrypoint#556sky-coderay wants to merge 1 commit intobase:mainfrom
sky-coderay wants to merge 1 commit intobase:mainfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
Collaborator
|
thanks for the pr this was fixed in http://github.com/base/node/pull/553#pullrequestreview-3315880570 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a runtime error where the script would validate NETWORK but then use OP_NODE_NETWORK in the configuration, causing potential startup failures