fix: conditionally include SnapshotRetentionLimit and add SnapshottingClusterId#1
Open
aaronwalker wants to merge 3 commits into
Open
fix: conditionally include SnapshotRetentionLimit and add SnapshottingClusterId#1aaronwalker wants to merge 3 commits into
aaronwalker wants to merge 3 commits into
Conversation
added 3 commits
April 27, 2026 12:20
…gClusterId support SnapshotRetentionLimit was unconditionally passed as a Ref, causing Integer type validation errors when the parameter was an empty string. Now uses AWS::NoValue when empty, leaving manual backup config untouched. Also adds SnapshottingClusterId parameter (required by ElastiCache when enabling SnapshotRetentionLimit via CloudFormation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnapshotRetentionLimit was unconditionally passed as a Ref. When empty, CF threw Integer type validation errors. Also adds SnapshottingClusterId support (required when enabling SnapshotRetentionLimit). Both use AWS::NoValue when empty, leaving manual config untouched.