Skip to content

Commit ba7ab61

Browse files
author
Marc Schlaeppi
committed
Remove redundant note overflow menu
1 parent d3e291b commit ba7ab61

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

source/app/blueprints/pages/case/templates/case_notes_v2.html

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,6 @@ <h4 class="page-title mb-0" id="currentNoteTitle"></h4>
9797
<i class="fa-solid fa-trash mr-2 text-danger"></i>
9898
</span>
9999
</button>
100-
<div class="dropdown">
101-
<button type="button" class="btn bg-transparent" id="noteQuickActionsToggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" title="More note actions" aria-label="More note actions">
102-
<span aria-hidden="true"><i class="fas fa-ellipsis-v"></i></span>
103-
</button>
104-
<div class="dropdown-menu pull-right" id="note_quick_actions" aria-labelledby="noteQuickActionsToggle">
105-
<a class="dropdown-item" href="#" onclick="load_note_revisions();return false;"><i class="fa-solid fa-clock-rotate-left mr-2"></i>Revision history</a>
106-
</div>
107-
</div>
108100
</div>
109101
</div>
110102
</div>

ui/test/note_overflow_menu.test.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@ import test from 'node:test';
44

55
const templateUrl = new URL('../../source/app/blueprints/pages/case/templates/case_notes_v2.html', import.meta.url);
66

7-
test('note overflow menu always exposes revision history', async () => {
7+
test('note toolbar keeps its revision history control without a redundant overflow menu', async () => {
88
const template = await readFile(templateUrl, 'utf8');
99

10-
assert.match(template, /id="noteQuickActionsToggle"[^>]*data-toggle="dropdown"/);
11-
assert.match(template, /id="note_quick_actions"[^>]*aria-labelledby="noteQuickActionsToggle"/);
12-
assert.match(template, /onclick="load_note_revisions\(\);return false;"[^>]*>.*Revision history/s);
10+
assert.match(template, /onclick="load_note_revisions\(\)"/);
11+
assert.doesNotMatch(template, /noteQuickActionsToggle|note_quick_actions|fa-ellipsis-v/);
1312
});

0 commit comments

Comments
 (0)