Skip to content

Commit 428c7a0

Browse files
committed
Address remaining PR review comments
1 parent 086cdcc commit 428c7a0

7 files changed

Lines changed: 18 additions & 6 deletions

File tree

internal/commands/activity.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ var activityListCmd = &cobra.Command{
2424
Use: "list",
2525
Short: "List activities",
2626
Long: "Lists activities with optional board and creator filters.",
27+
Args: cobra.NoArgs,
2728
RunE: func(cmd *cobra.Command, args []string) error {
2829
if err := requireAuthAndAccount(); err != nil {
2930
return err

internal/commands/activity_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,12 @@ func TestActivityList(t *testing.T) {
160160
}
161161
})
162162

163+
t.Run("rejects positional args", func(t *testing.T) {
164+
if err := activityListCmd.Args(activityListCmd, []string{"unexpected"}); err == nil {
165+
t.Fatal("expected positional args to be rejected")
166+
}
167+
})
168+
163169
t.Run("requires authentication", func(t *testing.T) {
164170
mock := NewMockClient()
165171
SetTestModeWithSDK(mock)

internal/commands/board.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -423,6 +423,7 @@ var boardAccessesCmd = &cobra.Command{
423423
Use: "accesses",
424424
Short: "Show board accesses",
425425
Long: "Shows access settings and users for a board.",
426+
Args: cobra.NoArgs,
426427
RunE: func(cmd *cobra.Command, args []string) error {
427428
if err := requireAuthAndAccount(); err != nil {
428429
return err

internal/commands/board_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -761,6 +761,12 @@ func TestBoardAccesses(t *testing.T) {
761761
}
762762
})
763763

764+
t.Run("rejects positional args", func(t *testing.T) {
765+
if err := boardAccessesCmd.Args(boardAccessesCmd, []string{"unexpected"}); err == nil {
766+
t.Fatal("expected positional args to be rejected")
767+
}
768+
})
769+
764770
t.Run("requires board", func(t *testing.T) {
765771
mock := NewMockClient()
766772
SetTestModeWithSDK(mock)

internal/commands/card.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,7 @@ var cardListCmd = &cobra.Command{
7676
}
7777
effectiveIndexedBy = "maybe"
7878
default:
79-
if effectiveIndexedBy != "" {
80-
return errors.NewInvalidArgsError("cannot combine --indexed-by with --column")
81-
}
82-
params = append(params, "column_ids[]="+columnFilter)
79+
return errors.NewInvalidArgsError("invalid pseudo-column kind: " + pseudo.Kind)
8380
}
8481
} else {
8582
if effectiveIndexedBy != "" {

internal/commands/pseudocolumns.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ type pseudoColumn struct {
1111
var (
1212
// "Not Now" contains postponed cards (indexed_by=not_now)
1313
pseudoColumnNotNow = pseudoColumn{ID: "not-now", Name: "Not Now", Kind: "not_now"}
14-
// "Maybe?" contains triage/backlog cards (indexed_by=maybe)
14+
// "Maybe?" contains triage/backlog cards. Kind remains "triage" for triage endpoints/aliases;
15+
// card listing maps this pseudo-column to indexed_by=maybe server-side.
1516
pseudoColumnMaybe = pseudoColumn{ID: "maybe", Name: "Maybe?", Kind: "triage"}
1617
// "Done" contains closed cards (indexed_by=closed)
1718
pseudoColumnDone = pseudoColumn{ID: "done", Name: "Done", Kind: "closed"}

skills/fizzy/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ Want to change something?
109109
| step | `step list --card NUMBER` | `step show ID --card NUMBER` | `step create` | `step update ID` | `step delete ID` | - |
110110
| reaction | `reaction list` | - | `reaction create` | - | `reaction delete ID` | - |
111111
| tag | `tag list` | - | - | - | - | - |
112-
| user | `user list` | `user show ID`, `user export-show USER_ID EXPORT_ID` | `user export-create USER_ID`, `user email-change-request USER_ID --email user@example.com`, `user email-change-confirm USER_ID TOKEN` | `user update ID` | - | `user deactivate ID`, `user role ID`, `user avatar-remove ID`, `user push-subscription-create`, `user push-subscription-delete ID` |
112+
| user | `user list` | `user show ID` | - | `user update ID` | - | `user deactivate ID`, `user role ID`, `user avatar-remove ID`, `user export-create USER_ID`, `user export-show USER_ID EXPORT_ID`, `user email-change-request USER_ID --email user@example.com`, `user email-change-confirm USER_ID TOKEN`, `user push-subscription-create`, `user push-subscription-delete ID` |
113113
| notification | `notification list` | - | - | - | - | `notification tray`, `notification read-all`, `notification settings-show`, `notification settings-update` |
114114
| pin | `pin list` | - | - | - | - | `card pin NUMBER`, `card unpin NUMBER` |
115115
| webhook | `webhook list --board ID`, `webhook deliveries --board ID WEBHOOK_ID` | `webhook show ID --board ID` | `webhook create` | `webhook update ID` | `webhook delete ID` | `webhook reactivate ID` |

0 commit comments

Comments
 (0)