Skip to content

Commit 46a580f

Browse files
authored
ci: drop approve step from Dependabot auto-merge (#156)
The approve step requires "Allow GitHub Actions to create and approve pull requests" at the repo level, which is off here, so the workflow fails on approve and the auto-merge step never runs. Without branch protection requiring reviews, the approve was cosmetic anyway — the auto-merge step alone gates on CI, which is the actual safety check.
1 parent 72e6994 commit 46a580f

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

.github/workflows/dependabot-auto-merge.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,6 @@ jobs:
1919
github-token: ${{ secrets.GITHUB_TOKEN }}
2020

2121
# CI is the safety gate — auto-merging action updates is circular.
22-
- name: Approve patch and minor updates (excluding actions)
23-
if: >-
24-
(
25-
steps.metadata.outputs.update-type == 'version-update:semver-patch' ||
26-
steps.metadata.outputs.update-type == 'version-update:semver-minor'
27-
) &&
28-
steps.metadata.outputs.package-ecosystem != 'github_actions'
29-
run: gh pr review --approve "$PR_URL"
30-
env:
31-
PR_URL: ${{ github.event.pull_request.html_url }}
32-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
33-
3422
- name: Enable auto-merge for patch and minor updates (excluding actions)
3523
if: >-
3624
(

0 commit comments

Comments
 (0)