Skip to content

fix: properly dispose of the client#1344

Merged
skovhus merged 2 commits into
bash-lsp:mainfrom
sadan4:fix/dispose-client
Oct 5, 2025
Merged

fix: properly dispose of the client#1344
skovhus merged 2 commits into
bash-lsp:mainfrom
sadan4:fix/dispose-client

Conversation

@sadan4

@sadan4 sadan4 commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

this fixes a bug introduced in 119f32a (and somehow not noticed in 6eb243e ????)

sadan4 and others added 2 commits October 4, 2025 01:23
this fixes a bug introduced in 119f32a
(and somehow not noticed in 6eb243e
????)
@skovhus
skovhus enabled auto-merge October 5, 2025 08:42
@skovhus

skovhus commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

@mads-hartmann, we need to update the vscode Personal Access Token.

@skovhus
skovhus merged commit 8e94fe0 into bash-lsp:main Oct 5, 2025
4 checks passed
@codecov

codecov Bot commented Oct 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.74%. Comparing base (29d81c7) to head (295659e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
vscode-client/src/extension.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1344      +/-   ##
==========================================
+ Coverage   80.63%   80.74%   +0.10%     
==========================================
  Files          29       29              
  Lines        1503     1501       -2     
  Branches      371      371              
==========================================
  Hits         1212     1212              
+ Misses        233      231       -2     
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants