final cleanup

Author: bashbaug

include/bfloat16.hpp

@@ -1,3 +1,8 @@
+/*
+// Copyright (c) 2024-2026 Ben Ashbaugh
+//
+// SPDX-License-Identifier: MIT
+*/
 #pragma once
 
 #include <cmath>

include/util.hpp

@@ -7,6 +7,9 @@
 
 #include <CL/opencl.hpp>
 
+#include <cctype>
+#include <cstdio>
+#include <cstring>
 #include <fstream>
 #include <iterator>
 #include <string>

samples/20_matrixexperiments-bf16/main.cpp

@@ -10,10 +10,12 @@
 
 #include <algorithm>
 #include <chrono>
+#include <cmath>
+#include <cstdint>
 #include <iostream>
+#include <random>
 #include <sstream>
 #include <string>
-#include <random>
 #include <vector>
 
 #include "bfloat16.hpp"

samples/20_matrixexperiments-i8/README.md

@@ -52,7 +52,6 @@ This sample will optionally use the following OpenCL extensions:
 | `--wallclock` | n/a | Measure performance using wallclock time instead of event profiling.
 | `--skipinit` | n/a | Skip initialization of source matrices.
 | `--roundrobin` | n/a | Use round robin thread scheduling.
-| `--threshold <float>` | 0.01 | Set the threshold used when validating results.
 | `--mask <int>` | ~0 | Set a mask to only run a subset of tests.
 
 By default, the source matrices are populated with random data.

samples/20_matrixexperiments-i8/main.cpp

@@ -10,10 +10,12 @@
 
 #include <algorithm>
 #include <chrono>
+#include <cmath>
+#include <cstdint>
 #include <iostream>
+#include <random>
 #include <sstream>
 #include <string>
-#include <random>
 #include <vector>
 
 #include "util.hpp"
@@ -29,7 +31,6 @@ bool wallclock = false;
 bool skipinit = false;
 bool roundRobin = false;
 int testIterations = 16;
-float threshold = 0.01f;
 
 std::string makeTestName(
     const std::string &func,
@@ -160,7 +161,6 @@ void check_results(
     const std::vector<T>& C,
     const std::vector<T>& C_ref)
 {
-    float err = 0.f;
     for (size_t m = 0; m < M; m++) {
         for (size_t n = 0; n < N; n++) {
             auto index = m * N + n;
@@ -491,7 +491,6 @@ int main(int argc, char** argv)
         op.add<popl::Switch>("", "wallclock", "Measure Wallclock Time", &wallclock);
         op.add<popl::Switch>("", "skipinit", "Do Not Initialize Buffers", &skipinit);
         op.add<popl::Switch>("", "roundrobin", "Use Round Robin Scheduling", &roundRobin);
-        op.add<popl::Value<float>>("", "threshold", "Local Error Threshold", threshold, &threshold);
         op.add<popl::Value<size_t>, popl::Attribute::advanced>("", "mask", "Test Mask", mask, &mask);
         bool printUsage = false;
         try {

samples/20_matrixexperiments-tf32/main.cpp

@@ -10,10 +10,12 @@
 
 #include <algorithm>
 #include <chrono>
+#include <cmath>
+#include <cstdint>
 #include <iostream>
+#include <random>
 #include <sstream>
 #include <string>
-#include <random>
 #include <vector>
 
 #include "util.hpp"