Merge pull request #847 from bashtage/fix-pytest-strict

TST: Ensure IDs are unique

Author: bashtage

arch/tests/univariate/test_mean.py

@@ -152,7 +152,7 @@ def forecastable_model(request) -> tuple[ARCHModelResult, ARCHModelFixedResult]:
     FIT_FIXED_PARAMS.append(pytest.param((model, vol), marks=marks))
 
 FIT_FIXED_IDS = [
-    f"{param[0][0].__class__.__name__}-{param[0][1]}{' (SLOW)' if len(mark) else ''}"
+    f"{param[0][0].name}-{param[0][1]}{' (SLOW)' if len(mark) else ''}"
     for param, mark, _ in FIT_FIXED_PARAMS
 ]
 

arch/univariate/base.py

@@ -380,7 +380,7 @@ def _fit_parameterless_model(
         """
         y = self._fit_y
         # Fake convergence results, see GH #87
-        opt = cast(Any, OptimizeResult())
+        opt = cast("Any", OptimizeResult())
         opt.status = 0
         opt.message = ""
 

arch/univariate/mean.py

@@ -776,7 +776,7 @@ def _fit_no_arch_normal_errors(
         y = self._fit_y
 
         # Fake convergence results, see GH #87
-        opt = cast(Any, OptimizeResult())
+        opt = cast("Any", OptimizeResult())
         opt.status = 0
         opt.message = ""
 

pyproject.toml

@@ -299,8 +299,8 @@ ignore = [
 "arch/unitroot/_phillips_ouliaris.py" = ["RUF002"]
 "arch/unitroot/_engle_granger.py" = ["RUF001"]
 
-
 [tool.pytest.ini_options]
+strict_parametrization_ids = true
 minversion = "8.4.1"
 testpaths = "arch"
 xfail_strict = true