TST: Update setup and remove exception

Remove bare exceptions
Update setup
Move flake8 run

Author: bashtage

.travis.yml

@@ -91,11 +91,11 @@ install:
 
 script:
   - set -e
-  - flake8 arch
   - pytest --cov-config .coveragerc --cov=arch arch --durations=10
   - python ci/performance.py
   - if [[ ${DOCBUILD} = true ]]; then cd doc && make html && cd .. ; fi
   - if [[ ${DOCBUILD} = true && ${TRAVIS_BRANCH} = "master" ]]; then doctr deploy doc; fi
+  - flake8 arch
 
 after_success:
   - if [[ ${COVERAGE} = true ]]; then coveralls --rcfile=${SRCDIR}/.coveragerc; fi

arch/bootstrap/base.py

@@ -577,7 +577,7 @@ def apply(self, func, reps=1000, extra_kwargs=None):
         base = func(*self._args, **kwargs)
         try:
             num_params = base.shape[0]
-        except:
+        except AttributeError:
             num_params = 1
         results = np.zeros((reps, num_params))
         count = 0

arch/tests/univariate/test_volatility.py

@@ -7,7 +7,7 @@
 
 try:
     from arch.univariate import _recursions as rec
-except:
+except ImportError:
     from arch.univariate import recursions_python as rec
 from arch.univariate.volatility import GARCH, ARCH, HARCH, ConstantVariance, \
     EWMAVariance, RiskMetrics2006, EGARCH, FixedVariance

setup.py

@@ -141,7 +141,7 @@ def strip_rc(version):
             from pandas.version import short_version as version
         except ImportError:
             pass
-        except:  # very old version
+        finally:  # very old version
             satisfies_req = False
     else:
         raise NotImplementedError('Unknown package')
@@ -209,7 +209,7 @@ def strip_rc(version):
                     with open(resource_filename, 'wb') as resource:
                         resource.write(resources['outputs'][key])
 
-        except:
+        except Exception:
             import warnings
 
             warnings.warn('Unable to convert {original} to {target}.  This '
@@ -223,7 +223,7 @@ def strip_rc(version):
             print(sys.exc_info()[0])
             print(sys.exc_info()[1])
 
-except:
+except Exception:
     import warnings
 
     warnings.warn('Unable to import required modules from the jupyter project.'