basic-memory/test-int/mcp/test_string_params_integration.py at d76a5ae8979f0e890e4b91ef1c1606a584fbcae9 · basicmachines-co/basic-memory · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
"""Integration tests for MCP tools accepting string-serialized list/dict params.

Goes through the full FastMCP Client → validate_call → tool function path,
which is where Pydantic rejects strings for list/dict params.
"""

import pytest
from fastmcp import Client


@pytest.mark.asyncio
async def test_search_notes_entity_types_as_string(mcp_server, app, test_project):
    """search_notes should accept entity_types as a JSON string via MCP protocol."""
    async with Client(mcp_server) as client:
        await client.call_tool(
            "write_note",
            {
                "project": test_project.name,
                "title": "Entity Type Coerce Test",
                "directory": "test",
                "content": "# Test\nContent for entity type coercion",
            },
        )

        # MCP client sends entity_types as a string
        result = await client.call_tool(
            "search_notes",
            {
                "project": test_project.name,
                "query": "coercion",
                "entity_types": '["entity"]',
            },
        )
        text = result.content[0].text
        assert "Search Failed" not in text


@pytest.mark.asyncio
async def test_search_notes_note_types_as_string(mcp_server, app, test_project):
    """search_notes should accept note_types as a JSON string via MCP protocol."""
    async with Client(mcp_server) as client:
        await client.call_tool(
            "write_note",
            {
                "project": test_project.name,
                "title": "Note Type Coerce Test",
                "directory": "test",
                "content": "# Test\nContent for note type coercion",
            },
        )

        result = await client.call_tool(
            "search_notes",
            {
                "project": test_project.name,
                "query": "coercion",
                "note_types": '["note"]',
            },
        )
        text = result.content[0].text
        assert "Search Failed" not in text


@pytest.mark.asyncio
async def test_search_notes_tags_as_string(mcp_server, app, test_project):
    """search_notes should accept tags as a JSON string via MCP protocol."""
    async with Client(mcp_server) as client:
        await client.call_tool(
            "write_note",
            {
                "project": test_project.name,
                "title": "Tags Coerce Test",
                "directory": "test",
                "content": "# Test\nTagged content for coercion",
                "tags": "alpha",
            },
        )

        result = await client.call_tool(
            "search_notes",
            {
                "project": test_project.name,
                "query": "tagged",
                "tags": '["alpha"]',
            },
        )
        text = result.content[0].text
        assert "Search Failed" not in text


@pytest.mark.asyncio
async def test_search_notes_metadata_filters_as_string(mcp_server, app, test_project):
    """search_notes should accept metadata_filters as a JSON string via MCP protocol."""
    async with Client(mcp_server) as client:
        await client.call_tool(
            "write_note",
            {
                "project": test_project.name,
                "title": "Metadata Coerce Test",
                "directory": "test",
                "content": "# Test\nMetadata content for coercion",
            },
        )

        result = await client.call_tool(
            "search_notes",
            {
                "project": test_project.name,
                "query": "metadata",
                "metadata_filters": '{"type": "note"}',
            },
        )
        text = result.content[0].text
        assert "Search Failed" not in text


@pytest.mark.asyncio
async def test_write_note_metadata_as_string(mcp_server, app, test_project):
    """write_note should accept metadata as a JSON string via MCP protocol."""
    async with Client(mcp_server) as client:
        result = await client.call_tool(
            "write_note",
            {
                "project": test_project.name,
                "title": "String Metadata Note",
                "directory": "test",
                "content": "# Test\nWith string metadata",
                "metadata": '{"priority": "high"}',
            },
        )
        text = result.content[0].text
        assert "Created note" in text or "Updated note" in text


@pytest.mark.asyncio
async def test_canvas_nodes_edges_as_string(mcp_server, app, test_project):
    """canvas should accept nodes and edges as JSON strings via MCP protocol."""
    import json

    nodes = [
        {
            "id": "n1",
            "type": "text",
            "text": "Hello",
            "x": 0,
            "y": 0,
            "width": 200,
            "height": 100,
        }
    ]
    edges = [
        {"id": "e1", "fromNode": "n1", "toNode": "n1", "label": "self"}
    ]

    async with Client(mcp_server) as client:
        result = await client.call_tool(
            "canvas",
            {
                "project": test_project.name,
                "title": "Coerce Canvas Test",
                "directory": "test",
                "nodes": json.dumps(nodes),
                "edges": json.dumps(edges),
            },
        )
        text = result.content[0].text
        assert "Created" in text or "Updated" in text