fix: Various rclone fixes for cloud sync on Windows

Author: bdmayes

src/basic_memory/cli/commands/cloud/bisync_commands.py

@@ -1,6 +1,7 @@
 """Cloud bisync commands for Basic Memory CLI."""
 
 import asyncio
+import platform
 import subprocess
 import time
 from datetime import datetime
@@ -167,16 +168,40 @@ def validate_bisync_directory(bisync_dir: Path) -> None:
             f"  2. Specify different directory: --dir ~/my-sync-folder"
         )
 
-    # Check if mount is active at this location
-    result = subprocess.run(["mount"], capture_output=True, text=True)
-    if str(bisync_dir) in result.stdout and "rclone" in result.stdout:
-        raise BisyncError(
-            f"{bisync_dir} is currently mounted via 'bm cloud mount'\n"
-            f"Cannot use mounted directory for bisync.\n\n"
-            f"Either:\n"
-            f"  1. Unmount first: bm cloud unmount\n"
-            f"  2. Use different directory for bisync"
-        )
+    system = platform.system()
+    if system.lower() != "windows":
+        # Unix: check with mount command
+        result = subprocess.run(["mount"], capture_output=True, text=True)
+        if str(bisync_dir) in result.stdout and "rclone" in result.stdout:
+            raise BisyncError(
+                f"{bisync_dir} is currently mounted via 'bm cloud mount'\n"
+                f"Cannot use mounted directory for bisync.\n\n"
+                f"Either:\n"
+                f"  1. Unmount first: bm cloud unmount\n"
+                f"  2. Use different directory for bisync"
+            )
+    else:
+        # Windows: check for rclone mount process using this directory
+        try:
+            # Use 'wmic' to get running processes and their command lines
+            result = subprocess.run(
+                ["wmic", "process", "where", "name='rclone.exe'", "get", "CommandLine"],
+                capture_output=True,
+                text=True,
+            )
+            if result.returncode == 0:
+                for line in result.stdout.splitlines():
+                    if "mount" in line.lower() and str(bisync_dir) in line:
+                        raise BisyncError(
+                            f"{bisync_dir} appears to be mounted via 'bm cloud mount' (rclone process detected)\n"
+                            f"Cannot use mounted directory for bisync.\n\n"
+                            f"Either:\n"
+                            f"  1. Unmount first: bm cloud unmount\n"
+                            f"  2. Use different directory for bisync"
+                        )
+        except Exception:
+            # If wmic is not available, skip the check (or optionally warn)
+            pass
 
 
 def convert_bmignore_to_rclone_filters() -> Path:

src/basic_memory/cli/commands/cloud/rclone_installer.py

@@ -1,5 +1,6 @@
 """Cross-platform rclone installation utilities."""
 
+import os
 import platform
 import shutil
 import subprocess
@@ -116,7 +117,15 @@ def install_rclone_windows() -> None:
     if shutil.which("winget"):
         try:
             console.print("[blue]Installing rclone via winget...[/blue]")
-            run_command(["winget", "install", "Rclone.Rclone"])
+            run_command(
+                [
+                    "winget",
+                    "install",
+                    "Rclone.Rclone",
+                    "--accept-source-agreements",
+                    "--accept-package-agreements",
+                ]
+            )
             console.print("[green]✓ rclone installed via winget[/green]")
             return
         except RcloneInstallError:
@@ -165,6 +174,7 @@ def install_rclone(platform_override: Optional[str] = None) -> None:
             install_rclone_linux()
         elif platform_name == "windows":
             install_rclone_windows()
+            refresh_windows_path()
         else:
             raise RcloneInstallError(f"Unsupported platform: {platform_name}")
 
@@ -180,6 +190,47 @@ def install_rclone(platform_override: Optional[str] = None) -> None:
         raise RcloneInstallError(f"Unexpected error during installation: {e}") from e
 
 
+def refresh_windows_path() -> None:
+    """Refresh the Windows PATH environment variable for the current session."""
+    if platform.system().lower() != "windows":
+        return
+
+    # Importing here after performing platform detection. Also note that we have to ignore pylance/pyright
+    # warnings about winreg attributes so that "errors" don't appear on non-Windows platforms.
+    import winreg
+
+    user_key_path = r"Environment"
+    system_key_path = r"System\CurrentControlSet\Control\Session Manager\Environment"
+    new_path = ""
+
+    # Read user PATH
+    try:
+        reg_key = winreg.OpenKey(winreg.HKEY_CURRENT_USER, user_key_path, 0, winreg.KEY_READ)  # type: ignore[reportAttributeAccessIssue]
+        user_path, _ = winreg.QueryValueEx(reg_key, "PATH")  # type: ignore[reportAttributeAccessIssue]
+        winreg.CloseKey(reg_key)  # type: ignore[reportAttributeAccessIssue]
+    except Exception:
+        user_path = ""
+
+    # Read system PATH
+    try:
+        reg_key = winreg.OpenKey(winreg.HKEY_LOCAL_MACHINE, system_key_path, 0, winreg.KEY_READ)  # type: ignore[reportAttributeAccessIssue]
+        system_path, _ = winreg.QueryValueEx(reg_key, "PATH")  # type: ignore[reportAttributeAccessIssue]
+        winreg.CloseKey(reg_key)  # type: ignore[reportAttributeAccessIssue]
+    except Exception:
+        system_path = ""
+
+    # Merge user and system PATHs (system first, then user)
+    if system_path and user_path:
+        new_path = system_path + ";" + user_path
+    elif system_path:
+        new_path = system_path
+    elif user_path:
+        new_path = user_path
+
+    if new_path:
+        os.environ["PATH"] = new_path
+
+
 def get_rclone_version() -> Optional[str]:
     """Get the installed rclone version."""
     if not is_rclone_installed():

tests/markdown/test_date_frontmatter_parsing.py

@@ -6,7 +6,6 @@
 """
 
 import pytest
-from pathlib import Path
 from basic_memory.markdown.entity_parser import EntityParser
 
 
@@ -225,11 +224,13 @@ async def test_parse_file_with_datetime_objects(tmp_path):
     created_at = entity_markdown.frontmatter.metadata.get("created_at")
     assert isinstance(created_at, str), "Datetime should be converted to string"
     # PyYAML parses "2025-10-24 14:30:00" as datetime, which we normalize to ISO
-    assert "2025-10-24" in created_at and "14:30:00" in created_at, \
+    assert "2025-10-24" in created_at and "14:30:00" in created_at, (
         f"Datetime with time should be normalized to ISO format, got: {created_at}"
+    )
 
     updated_at = entity_markdown.frontmatter.metadata.get("updated_at")
     assert isinstance(updated_at, str), "Datetime should be converted to string"
     # PyYAML parses "2025-10-24T00:00:00" as datetime, which we normalize to ISO
-    assert "2025-10-24" in updated_at and "00:00:00" in updated_at, \
-        f"Datetime at midnight should be normalized to ISO format, got: {updated_at}"
+    assert "2025-10-24" in updated_at and "00:00:00" in updated_at, (
+        f"Datetime at midnight should be normalized to ISO format, got: {updated_at}"
+    )