ci(mcp): fix PR check failures

Signed-off-by: Drew Cain <groksrc@gmail.com>

Author: groksrc

AGENTS.md

@@ -56,6 +56,15 @@ Run `just test-smoke` when you specifically need the MCP smoke flow.
 
 If testmon is “cold,” the first run may be long. Subsequent runs get much faster.
 
+### PR CI Gate
+
+Before opening or updating a PR, run the checks that mirror the common required CI failures:
+
+- Run `just typecheck` in addition to targeted `ruff` and `pytest` commands when tests were added or changed.
+- Sign commits with `git commit -s` so DCO passes. If a PR branch already has unsigned commits, rewrite the branch with signed-off commits before asking for review.
+- Use a semantic PR title accepted by `.github/workflows/pr-title.yml`: `type(scope): summary`.
+- Use one of the allowed scopes: `core`, `cli`, `api`, `mcp`, `sync`, `ui`, `deps`, `installer`.
+
 ### Test Structure
 
 - `tests/` - Unit tests for individual components (mocked, fast)

tests/mcp/test_tool_read_note.py

@@ -3,6 +3,7 @@
 from contextlib import asynccontextmanager
 from types import SimpleNamespace
 from textwrap import dedent
+from typing import Any, cast
 
 import pytest
 
@@ -24,6 +25,10 @@ async def set_state(self, key: str, value: object, **kwargs) -> None:
         self._state[key] = value
 
 
+def _ctx(context: _ContextState) -> Any:
+    return cast(Any, context)
+
+
 def test_parse_opening_frontmatter_handles_crlf():
     """JSON read_note output should strip frontmatter from Windows-written markdown."""
     body, frontmatter = _parse_opening_frontmatter(
@@ -297,7 +302,7 @@ async def read(self, entity_id: str):
         "memory://todo",
         project="personal/main",
         output_format="json",
-        context=context,
+        context=_ctx(context),
     )
 
     assert isinstance(result, dict)

tests/mcp/test_tool_search.py

@@ -4,6 +4,7 @@
 from contextlib import asynccontextmanager
 from datetime import datetime, timedelta
 from types import SimpleNamespace
+from typing import cast
 
 from basic_memory.mcp.tools import write_note
 from basic_memory.mcp.tools.search import (
@@ -269,7 +270,8 @@ async def search(self, payload, *, page, page_size):
     assert captured["project"] == "personal/main"
     assert captured["project_id"] is None
     assert captured["search_project_id"] == "11111111-1111-1111-1111-111111111111"
-    assert captured["payload"]["permalink"] == "personal/main/tests/search-note"
+    payload = cast(dict[str, object], captured["payload"])
+    assert payload["permalink"] == "personal/main/tests/search-note"
     assert isinstance(response, dict)
     assert response["results"][0]["permalink"] == "personal/main/tests/search-note"