fix: Fix v2 API test failures and add numeric ID support

This commit fixes all failing tests in the v2 API test suite by addressing
several issues:

1. Memory Router Tests:
   - Created helper function create_test_entity() to properly create files,
     entities, and index them for search
   - Applied helper to all tests that require indexed entities
   - Fixed GraphContext response expectations ('results' not 'entities')

2. Resource Router Tests:
   - Added project_id to entity_data in test_get_resource_by_id
   - Fixed expected status code from 400 to 422 for validation errors
   - Added numeric ID lookup support in resource_router.py
   - Router now checks if identifier is digit and looks up by entity ID

3. Search Router Tests:
   - Created helper function create_test_entity() for file + entity + indexing
   - Applied helper to all 6 tests that create and index entities
   - Added missing content_type field to entity_data

All 62 v2 API tests now pass successfully.

Signed-off-by: Claude <noreply@anthropic.com>

Author: jope-bm

src/basic_memory/api/v2/routers/resource_router.py

@@ -88,8 +88,18 @@ async def get_resource_content(
     """
     logger.debug(f"V2 Getting content for project {project_id}, identifier: {identifier}")
 
-    # Find single entity by permalink or ID
-    entity = await link_resolver.resolve_link(identifier)
+    # Try numeric ID lookup first (V2 feature)
+    entity = None
+    if identifier.isdigit():
+        entity_id = int(identifier)
+        entities = await entity_service.get_entities_by_id([entity_id])
+        entity = entities[0] if entities else None
+        logger.debug(f"Numeric ID lookup: {'found' if entity else 'not found'}")
+
+    # Fall back to link resolver for permalinks/paths
+    if not entity:
+        entity = await link_resolver.resolve_link(identifier)
+
     results = [entity] if entity else []
 
     # pagination for multiple results

tests/api/v2/test_memory_router.py

@@ -63,6 +63,7 @@ async def test_get_recent_context_with_pagination(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test recent context with pagination parameters."""
     # Create multiple test entities
@@ -74,8 +75,7 @@ async def test_get_recent_context_with_pagination(
             "file_path": f"entity_{i}.md",
             "checksum": f"checksum{i}",
         }
-        entity = await entity_repository.create(entity_data)
-        await search_service.index_entity(entity)
+        await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Get recent context with pagination
     response = await client.get(
@@ -97,6 +97,7 @@ async def test_get_recent_context_with_type_filter(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test filtering recent context by type."""
     # Create a test entity
@@ -107,8 +108,7 @@ async def test_get_recent_context_with_type_filter(
         "file_path": "filtered.md",
         "checksum": "xyz789",
     }
-    entity = await entity_repository.create(entity_data)
-    await search_service.index_entity(entity)
+    entity = await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Get recent context filtered by type
     response = await client.get(
@@ -155,6 +155,7 @@ async def test_get_memory_context_by_permalink(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test getting context for a specific memory URI (permalink)."""
     # Create a test entity
@@ -166,8 +167,7 @@ async def test_get_memory_context_by_permalink(
         "checksum": "def456",
         "permalink": "context-test",
     }
-    created_entity = await entity_repository.create(entity_data)
-    await search_service.index_entity(created_entity)
+    created_entity = await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Get context for this entity
     response = await client.get(f"{v2_project_url}/memory/context-test")
@@ -184,6 +184,7 @@ async def test_get_memory_context_by_id(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test getting context using ID-based memory URI."""
     # Create a test entity
@@ -194,8 +195,7 @@ async def test_get_memory_context_by_id(
         "file_path": "id_context_test.md",
         "checksum": "ghi789",
     }
-    created_entity = await entity_repository.create(entity_data)
-    await search_service.index_entity(created_entity)
+    created_entity = await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Get context using ID format (memory://id/123 or memory://123)
     response = await client.get(f"{v2_project_url}/memory/id/{created_entity.id}")
@@ -212,6 +212,7 @@ async def test_get_memory_context_with_depth(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test getting context with depth parameter."""
     # Create a test entity
@@ -223,8 +224,7 @@ async def test_get_memory_context_with_depth(
         "checksum": "jkl012",
         "permalink": "depth-test",
     }
-    entity = await entity_repository.create(entity_data)
-    await search_service.index_entity(entity)
+    entity = await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Get context with depth
     response = await client.get(
@@ -258,6 +258,7 @@ async def test_get_memory_context_with_timeframe(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test getting context with timeframe filter."""
     # Create a test entity
@@ -269,8 +270,7 @@ async def test_get_memory_context_with_timeframe(
         "checksum": "mno345",
         "permalink": "timeframe-test",
     }
-    entity = await entity_repository.create(entity_data)
-    await search_service.index_entity(entity)
+    entity = await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Get context with timeframe
     response = await client.get(

tests/api/v2/test_resource_router.py

@@ -29,6 +29,7 @@ async def test_get_resource_by_id(
         "content_type": "text/markdown",
         "file_path": "test_resource.md",
         "checksum": "res123",
+        "project_id": test_project.id,
     }
     created_entity = await entity_repository.create(entity_data)
 
@@ -279,8 +280,8 @@ async def test_write_resource_dict_content_fails(
         json={"content": "test"}  # This sends a dict, not a string
     )
 
-    # Should fail with validation error
-    assert response.status_code == 400
+    # Should fail with validation error (422 is FastAPI's validation error code)
+    assert response.status_code == 422
 
 
 @pytest.mark.asyncio

tests/api/v2/test_search_router.py

@@ -2,17 +2,36 @@
 
 import pytest
 from httpx import AsyncClient
+from pathlib import Path
 
 from basic_memory.models import Entity, Project
 
 
+async def create_test_entity(test_project, entity_data, entity_repository, search_service, file_service):
+    """Helper to create an entity with file and index it."""
+    # Create file
+    test_content = f"# {entity_data['title']}\n\nTest content"
+    file_path = Path(test_project.path) / entity_data["file_path"]
+    file_path.parent.mkdir(parents=True, exist_ok=True)
+    await file_service.write_file(file_path, test_content)
+
+    # Create entity
+    entity = await entity_repository.create(entity_data)
+
+    # Index for search
+    await search_service.index_entity(entity)
+
+    return entity
+
+
 @pytest.mark.asyncio
 async def test_search_entities(
     client: AsyncClient,
     test_project: Project,
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test searching for entities."""
     # Create a test entity
@@ -23,10 +42,7 @@ async def test_search_entities(
         "file_path": "searchable.md",
         "checksum": "search123",
     }
-    created_entity = await entity_repository.create(entity_data)
-
-    # Index the entity
-    await search_service.index_entity(created_entity)
+    created_entity = await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Search for the entity
     response = await client.post(
@@ -50,19 +66,19 @@ async def test_search_with_pagination(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test search with pagination parameters."""
     # Create multiple test entities
     for i in range(5):
         entity_data = {
             "title": f"Search Entity {i}",
             "entity_type": "note",
-        "content_type": "text/markdown",
+            "content_type": "text/markdown",
             "file_path": f"search_{i}.md",
             "checksum": f"searchsum{i}",
         }
-        entity = await entity_repository.create(entity_data)
-        await search_service.index_entity(entity)
+        await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Search with pagination
     response = await client.post(
@@ -84,6 +100,7 @@ async def test_search_by_permalink(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test searching by permalink."""
     # Create a test entity with permalink
@@ -95,8 +112,7 @@ async def test_search_by_permalink(
         "checksum": "perm123",
         "permalink": "permalink-search",
     }
-    entity = await entity_repository.create(entity_data)
-    await search_service.index_entity(entity)
+    await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Search by permalink
     response = await client.post(
@@ -116,6 +132,7 @@ async def test_search_by_title(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test searching by title."""
     # Create a test entity
@@ -126,8 +143,7 @@ async def test_search_by_title(
         "file_path": "unique_title.md",
         "checksum": "title123",
     }
-    entity = await entity_repository.create(entity_data)
-    await search_service.index_entity(entity)
+    await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Search by title
     response = await client.post(
@@ -147,18 +163,19 @@ async def test_search_with_type_filter(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test searching with entity type filter."""
     # Create test entities of different types
     for entity_type in ["note", "document"]:
         entity_data = {
             "title": f"Type {entity_type}",
             "entity_type": entity_type,
+            "content_type": "text/markdown",
             "file_path": f"type_{entity_type}.md",
             "checksum": f"type{entity_type}",
         }
-        entity = await entity_repository.create(entity_data)
-        await search_service.index_entity(entity)
+        await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Search with type filter
     response = await client.post(
@@ -178,6 +195,7 @@ async def test_search_with_date_filter(
     v2_project_url: str,
     entity_repository,
     search_service,
+    file_service,
 ):
     """Test searching with date filter."""
     # Create a test entity
@@ -188,8 +206,7 @@ async def test_search_with_date_filter(
         "file_path": "date_filtered.md",
         "checksum": "date123",
     }
-    entity = await entity_repository.create(entity_data)
-    await search_service.index_entity(entity)
+    await create_test_entity(test_project, entity_data, entity_repository, search_service, file_service)
 
     # Search with date filter
     response = await client.post(