feat: Add database IDs to all V2 API entity responses

Ensure all V2 API endpoints return database IDs for entities, observations,
and relations to enable consistent ID-based references across the API.

Schema changes:
- Add entity_id, observation_id, relation_id fields to SearchResult
- Add entity_id to EntitySummary
- Add relation_id, entity_id, from_entity_id, to_entity_id to RelationSummary
- Add observation_id, entity_id to ObservationSummary

Implementation changes:
- Update to_summary() to populate all entity/observation/relation IDs
- Update to_search_results() to set appropriate IDs based on type

Test updates:
- Update test fixtures to include new required ID fields
- All 180 V2 API tests passing
- All schema serialization tests passing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Joe P <joe@basicmemory.com>

Author: jope-bm

src/basic_memory/api/routers/utils.py

@@ -29,6 +29,7 @@ async def to_summary(item: SearchIndexRow | ContextResultRow):
         match item.type:
             case SearchItemType.ENTITY:
                 return EntitySummary(
+                    entity_id=item.id,
                     title=item.title,  # pyright: ignore
                     permalink=item.permalink,
                     content=item.content,
@@ -37,6 +38,8 @@ async def to_summary(item: SearchIndexRow | ContextResultRow):
                 )
             case SearchItemType.OBSERVATION:
                 return ObservationSummary(
+                    observation_id=item.id,
+                    entity_id=item.entity_id,  # pyright: ignore
                     title=item.title,  # pyright: ignore
                     file_path=item.file_path,
                     category=item.category,  # pyright: ignore
@@ -48,12 +51,16 @@ async def to_summary(item: SearchIndexRow | ContextResultRow):
                 from_entity = await entity_repository.find_by_id(item.from_id)  # pyright: ignore
                 to_entity = await entity_repository.find_by_id(item.to_id) if item.to_id else None
                 return RelationSummary(
+                    relation_id=item.id,
+                    entity_id=item.entity_id,  # pyright: ignore
                     title=item.title,  # pyright: ignore
                     file_path=item.file_path,
                     permalink=item.permalink,  # pyright: ignore
                     relation_type=item.relation_type,  # pyright: ignore
                     from_entity=from_entity.title if from_entity else None,
+                    from_entity_id=item.from_id,  # pyright: ignore
                     to_entity=to_entity.title if to_entity else None,
+                    to_entity_id=item.to_id,
                     created_at=item.created_at,
                 )
             case _:  # pragma: no cover
@@ -111,6 +118,21 @@ async def to_search_results(entity_service: EntityService, results: List[SearchI
     search_results = []
     for r in results:
         entities = await entity_service.get_entities_by_id([r.entity_id, r.from_id, r.to_id])  # pyright: ignore
+
+        # Determine which IDs to set based on type
+        entity_id = None
+        observation_id = None
+        relation_id = None
+
+        if r.type == SearchItemType.ENTITY:
+            entity_id = r.id
+        elif r.type == SearchItemType.OBSERVATION:
+            observation_id = r.id
+            entity_id = r.entity_id  # Parent entity
+        elif r.type == SearchItemType.RELATION:
+            relation_id = r.id
+            entity_id = r.entity_id  # Parent entity
+
         search_results.append(
             SearchResult(
                 title=r.title,  # pyright: ignore
@@ -121,6 +143,9 @@ async def to_search_results(entity_service: EntityService, results: List[SearchI
                 content=r.content,
                 file_path=r.file_path,
                 metadata=r.metadata,
+                entity_id=entity_id,
+                observation_id=observation_id,
+                relation_id=relation_id,
                 category=r.category,
                 from_entity=entities[0].permalink if entities else None,
                 to_entity=entities[1].permalink if len(entities) > 1 else None,

src/basic_memory/schemas/memory.py

@@ -124,6 +124,7 @@ class EntitySummary(BaseModel):
     """Simplified entity representation."""
 
     type: Literal["entity"] = "entity"
+    entity_id: int  # Database ID for v2 API consistency
     permalink: Optional[str]
     title: str
     content: Optional[str] = None
@@ -141,12 +142,16 @@ class RelationSummary(BaseModel):
     """Simplified relation representation."""
 
     type: Literal["relation"] = "relation"
+    relation_id: int  # Database ID for v2 API consistency
+    entity_id: Optional[int] = None  # ID of the entity this relation belongs to
     title: str
     file_path: str
     permalink: str
     relation_type: str
     from_entity: Optional[str] = None
+    from_entity_id: Optional[int] = None  # ID of source entity
     to_entity: Optional[str] = None
+    to_entity_id: Optional[int] = None  # ID of target entity
     created_at: Annotated[
         datetime, Field(json_schema_extra={"type": "string", "format": "date-time"})
     ]
@@ -160,6 +165,8 @@ class ObservationSummary(BaseModel):
     """Simplified observation representation."""
 
     type: Literal["observation"] = "observation"
+    observation_id: int  # Database ID for v2 API consistency
+    entity_id: Optional[int] = None  # ID of the entity this observation belongs to
     title: str
     file_path: str
     permalink: str

src/basic_memory/schemas/search.py

@@ -97,6 +97,11 @@ class SearchResult(BaseModel):
 
     metadata: Optional[dict] = None
 
+    # IDs for v2 API consistency
+    entity_id: Optional[int] = None  # Entity ID (always present for entities)
+    observation_id: Optional[int] = None  # Observation ID (for observation results)
+    relation_id: Optional[int] = None  # Relation ID (for relation results)
+
     # Type-specific fields
     category: Optional[str] = None  # For observations
     from_entity: Optional[Permalink] = None  # For relations

tests/api/test_continue_conversation_template.py

@@ -18,6 +18,7 @@ def template_loader():
 def entity_summary():
     """Create a sample EntitySummary for testing."""
     return EntitySummary(
+        entity_id=1,
         title="Test Entity",
         permalink="test/entity",
         type=SearchItemType.ENTITY,
@@ -34,6 +35,8 @@ def context_with_results(entity_summary):
 
     # Create an observation for the entity
     observation = ObservationSummary(
+        observation_id=1,
+        entity_id=1,
         title="Test Observation",
         permalink="test/entity/observations/1",
         category="test",

tests/mcp/test_prompts.py

@@ -116,6 +116,7 @@ def test_prompt_context_with_file_path_no_permalink():
 
     # Create a mock context with a file that has no permalink (like a binary file)
     test_entity = EntitySummary(
+        entity_id=1,
         type="entity",
         title="Test File",
         permalink=None,  # No permalink

tests/schemas/test_memory_serialization.py

@@ -22,6 +22,7 @@ def test_entity_summary_datetime_serialization(self):
         test_datetime = datetime(2023, 12, 8, 10, 30, 0)
 
         entity = EntitySummary(
+            entity_id=1,
             permalink="test/entity",
             title="Test Entity",
             file_path="test/entity.md",
@@ -41,6 +42,8 @@ def test_relation_summary_datetime_serialization(self):
         test_datetime = datetime(2023, 12, 8, 15, 45, 30)
 
         relation = RelationSummary(
+            relation_id=1,
+            entity_id=1,
             title="Test Relation",
             file_path="test/relation.md",
             permalink="test/relation",
@@ -63,6 +66,8 @@ def test_observation_summary_datetime_serialization(self):
         test_datetime = datetime(2023, 12, 8, 20, 15, 45)
 
         observation = ObservationSummary(
+            observation_id=1,
+            entity_id=1,
             title="Test Observation",
             file_path="test/observation.md",
             permalink="test/observation",
@@ -100,13 +105,16 @@ def test_context_result_with_datetime_serialization(self):
         test_datetime = datetime(2023, 12, 8, 9, 30, 15)
 
         entity = EntitySummary(
+            entity_id=1,
             permalink="test/entity",
             title="Test Entity",
             file_path="test/entity.md",
             created_at=test_datetime,
         )
 
         observation = ObservationSummary(
+            observation_id=1,
+            entity_id=1,
             title="Test Observation",
             file_path="test/observation.md",
             permalink="test/observation",
@@ -131,6 +139,7 @@ def test_graph_context_full_serialization(self):
         test_datetime = datetime(2023, 12, 8, 14, 20, 10)
 
         entity = EntitySummary(
+            entity_id=1,
             permalink="test/entity",
             title="Test Entity",
             file_path="test/entity.md",
@@ -159,6 +168,7 @@ def test_datetime_with_microseconds_serialization(self):
         test_datetime = datetime(2023, 12, 8, 10, 30, 0, 123456)
 
         entity = EntitySummary(
+            entity_id=1,
             permalink="test/entity",
             title="Test Entity",
             file_path="test/entity.md",
@@ -176,6 +186,7 @@ def test_mcp_schema_validation_compatibility(self):
         test_datetime = datetime(2023, 12, 8, 10, 30, 0)
 
         entity = EntitySummary(
+            entity_id=1,
             permalink="test/entity",
             title="Test Entity",
             file_path="test/entity.md",
@@ -212,10 +223,16 @@ def test_all_models_have_datetime_serializers_configured(self):
 
             if model_class == EntitySummary:
                 instance = model_class(
-                    permalink="test", title="Test", file_path="test.md", created_at=test_datetime
+                    entity_id=1,
+                    permalink="test",
+                    title="Test",
+                    file_path="test.md",
+                    created_at=test_datetime,
                 )
             elif model_class == RelationSummary:
                 instance = model_class(
+                    relation_id=1,
+                    entity_id=1,
                     title="Test",
                     file_path="test.md",
                     permalink="test",
@@ -224,6 +241,8 @@ def test_all_models_have_datetime_serializers_configured(self):
                 )
             elif model_class == ObservationSummary:
                 instance = model_class(
+                    observation_id=1,
+                    entity_id=1,
                     title="Test",
                     file_path="test.md",
                     permalink="test",