refactor: convert search.py to context manager pattern

Converts search tool to use async with get_client() context manager:

- Changed import from 'client' to 'get_client'
- Wrapped function body at line 356 in async with block
- Indented lines 357-384 inside context manager
- Tests: 16/16 passing
- Coverage: 96% for search.py

Tool provides comprehensive search functionality:
- Full-text search with FTS5 support
- Title and permalink search modes
- Advanced boolean operators (AND, OR, NOT)
- Pattern matching and filtering
- Helpful error messages with search syntax guidance

Total tools converted: 11/16 (Phase 0.3)

Updated SPEC-16 Phase 0.3 checklist to mark search.py as completed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

specs/SPEC-16 MCP Cloud Service Consolidation.md

@@ -455,7 +455,7 @@ Convert from `from async_client import client` to `async with get_client() as cl
 - [x] `tools/read_content.py` (20/20 tests passing)
 - [x] `tools/list_directory.py` (11/11 tests passing)
 - [x] `tools/move_note.py` (34/34 tests passing, 90% coverage)
-- [ ] `tools/search.py`
+- [x] `tools/search.py` (16/16 tests passing, 96% coverage)
 - [ ] `tools/recent_activity.py`
 - [ ] `tools/project_management.py`
 - [x] `tools/edit_note.py` (17/17 tests passing)

src/basic_memory/mcp/tools/search.py

@@ -6,7 +6,7 @@
 from loguru import logger
 from fastmcp import Context
 
-from basic_memory.mcp.async_client import client
+from basic_memory.mcp.async_client import get_client
 from basic_memory.mcp.project_context import get_active_project
 from basic_memory.mcp.server import mcp
 from basic_memory.mcp.tools.utils import call_post
@@ -353,31 +353,32 @@ async def search_notes(
     if after_date:
         search_query.after_date = after_date
 
-    active_project = await get_active_project(client, project, context)
-    project_url = active_project.project_url
+    async with get_client() as client:
+        active_project = await get_active_project(client, project, context)
+        project_url = active_project.project_url
 
-    logger.info(f"Searching for {search_query} in project {active_project.name}")
+        logger.info(f"Searching for {search_query} in project {active_project.name}")
 
-    try:
-        response = await call_post(
-            client,
-            f"{project_url}/search/",
-            json=search_query.model_dump(),
-            params={"page": page, "page_size": page_size},
-        )
-        result = SearchResponse.model_validate(response.json())
-
-        # Check if we got no results and provide helpful guidance
-        if not result.results:
-            logger.info(
-                f"Search returned no results for query: {query} in project {active_project.name}"
+        try:
+            response = await call_post(
+                client,
+                f"{project_url}/search/",
+                json=search_query.model_dump(),
+                params={"page": page, "page_size": page_size},
             )
-            # Don't treat this as an error, but the user might want guidance
-            # We return the empty result as normal - the user can decide if they need help
-
-        return result
-
-    except Exception as e:
-        logger.error(f"Search failed for query '{query}': {e}, project: {active_project.name}")
-        # Return formatted error message as string for better user experience
-        return _format_search_error_response(active_project.name, str(e), query, search_type)
+            result = SearchResponse.model_validate(response.json())
+
+            # Check if we got no results and provide helpful guidance
+            if not result.results:
+                logger.info(
+                    f"Search returned no results for query: {query} in project {active_project.name}"
+                )
+                # Don't treat this as an error, but the user might want guidance
+                # We return the empty result as normal - the user can decide if they need help
+
+            return result
+
+        except Exception as e:
+            logger.error(f"Search failed for query '{query}': {e}, project: {active_project.name}")
+            # Return formatted error message as string for better user experience
+            return _format_search_error_response(active_project.name, str(e), query, search_type)