fix: respect frontmatter entity_type in write_note operations

- Add frontmatter type extraction in EntityService.create_entity() and update_entity()
- Override schema.entity_type when content frontmatter contains 'type' field
- Fix lint error in alembic/env.py with noqa comment
- Update test formatting for consistency
- Ensures write_note respects both parameter and frontmatter entity_type values

Fixes #144

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: phernandez

src/basic_memory/alembic/env.py

@@ -13,7 +13,7 @@
 # set config.env to "test" for pytest to prevent logging to file in utils.setup_logging()
 os.environ["BASIC_MEMORY_ENV"] = "test"
 
-from basic_memory.config import app_config
+from basic_memory.config import app_config  # noqa: E402
 
 # this is the Alembic Config object, which provides
 # access to the values within the .ini file in use.

src/basic_memory/services/entity_service.py

@@ -117,10 +117,15 @@ async def create_entity(self, schema: EntitySchema) -> EntityModel:
                 f"file for entity {schema.folder}/{schema.title} already exists: {file_path}"
             )
 
-        # Parse content frontmatter to check for user-specified permalink
+        # Parse content frontmatter to check for user-specified permalink and entity_type
         content_markdown = None
         if schema.content and has_frontmatter(schema.content):
             content_frontmatter = parse_frontmatter(schema.content)
+
+            # If content has entity_type/type, use it to override the schema entity_type
+            if "type" in content_frontmatter:
+                schema.entity_type = content_frontmatter["type"]
+
             if "permalink" in content_frontmatter:
                 # Create a minimal EntityMarkdown object for permalink resolution
                 from basic_memory.markdown.schemas import EntityFrontmatter
@@ -172,10 +177,15 @@ async def update_entity(self, entity: EntityModel, schema: EntitySchema) -> Enti
         # Read existing frontmatter from the file if it exists
         existing_markdown = await self.entity_parser.parse_file(file_path)
 
-        # Parse content frontmatter to check for user-specified permalink
+        # Parse content frontmatter to check for user-specified permalink and entity_type
         content_markdown = None
         if schema.content and has_frontmatter(schema.content):
             content_frontmatter = parse_frontmatter(schema.content)
+
+            # If content has entity_type/type, use it to override the schema entity_type
+            if "type" in content_frontmatter:
+                schema.entity_type = content_frontmatter["type"]
+
             if "permalink" in content_frontmatter:
                 # Create a minimal EntityMarkdown object for permalink resolution
                 from basic_memory.markdown.schemas import EntityFrontmatter

tests/mcp/test_tool_write_note.py

@@ -418,8 +418,8 @@ async def test_write_note_preserves_content_frontmatter(app):
 @pytest.mark.asyncio
 async def test_write_note_with_custom_entity_type(app):
     """Test creating a note with custom entity_type parameter.
-    
-    This test verifies the fix for Issue #144 where entity_type parameter 
+
+    This test verifies the fix for Issue #144 where entity_type parameter
     was hardcoded to "note" instead of allowing custom types.
     """
     result = await write_note.fn(
@@ -503,7 +503,7 @@ async def test_write_note_with_config_entity_type(app):
 @pytest.mark.asyncio
 async def test_write_note_entity_type_default_behavior(app):
     """Test that the entity_type parameter defaults to "note" when not specified.
-    
+
     This ensures backward compatibility - existing code that doesn't specify
     entity_type should continue to work as before.
     """
@@ -559,10 +559,10 @@ async def test_write_note_update_existing_with_different_entity_type(app):
     assert "- guide" in content
 
 
-@pytest.mark.asyncio  
+@pytest.mark.asyncio
 async def test_write_note_respects_frontmatter_entity_type(app):
     """Test that entity_type in frontmatter is respected when parameter is not provided.
-    
+
     This verifies that when write_note is called without entity_type parameter,
     but the content includes frontmatter with a 'type' field, that type is respected
     instead of defaulting to 'note'.
@@ -582,11 +582,7 @@ async def test_write_note_respects_frontmatter_entity_type(app):
         """).strip()
 
     # Call write_note without entity_type parameter - it should respect frontmatter type
-    result = await write_note.fn(
-        title="Test Guide",
-        folder="guides", 
-        content=note
-    )
+    result = await write_note.fn(title="Test Guide", folder="guides", content=note)
 
     assert result
     assert "# Created note" in result