fix nt specific test failures

Signed-off-by: Drew Cain <groksrc@gmail.com>

Author: groksrc

.github/workflows/test.yml

@@ -14,11 +14,12 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
+        os: [ubuntu-latest, windows-latest]
         python-version: [ "3.12" ]
+    runs-on: ${{ matrix.os }}
 
     steps:
       - uses: actions/checkout@v4
@@ -35,10 +36,21 @@ jobs:
         run: |
           pip install uv
 
-      - name: Install just
+      - name: Install just (Linux/macOS)
+        if: runner.os != 'Windows'
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://just.systems/install.sh | bash -s -- --to /usr/local/bin
 
+      - name: Install just (Windows)
+        if: runner.os == 'Windows'
+        run: |
+          # Download and install just for Windows
+          $url = "https://github.com/casey/just/releases/latest/download/just-x86_64-pc-windows-msvc.zip"
+          Invoke-WebRequest -Uri $url -OutFile just.zip
+          Expand-Archive just.zip -DestinationPath .
+          Move-Item just.exe C:\Windows\System32\
+        shell: powershell
+
       - name: Create virtual env
         run: |
           uv venv
@@ -54,4 +66,4 @@ jobs:
       - name: Run tests
         run: |
           uv pip install pytest pytest-cov
-          just test
+          just test

tests/cli/test_project_commands.py

@@ -85,7 +85,12 @@ def test_project_default_command(mock_reload, mock_run, cli_env):
     # Patching call_put directly since it's imported at the module level
 
     # Patch the os.environ for checking
-    with patch.dict(os.environ, {}, clear=True):
+    # On Windows, preserve USERPROFILE to allow home directory detection
+    env_vars = {}
+    if os.name == 'nt' and 'USERPROFILE' in os.environ:
+        env_vars['USERPROFILE'] = os.environ['USERPROFILE']
+
+    with patch.dict(os.environ, env_vars, clear=True):
         # Patch ConfigManager.set_default_project to prevent validation error
         with patch("basic_memory.config.ConfigManager.set_default_project"):
             runner = CliRunner()

tests/conftest.py

@@ -6,6 +6,7 @@
 from textwrap import dedent
 from typing import AsyncGenerator
 
+import os
 import pytest
 import pytest_asyncio
 from sqlalchemy.ext.asyncio import AsyncEngine, AsyncSession, async_sessionmaker
@@ -51,6 +52,9 @@ def project_root() -> Path:
 def config_home(tmp_path, monkeypatch) -> Path:
     # Patch HOME environment variable for the duration of the test
     monkeypatch.setenv("HOME", str(tmp_path))
+    # On Windows, also set USERPROFILE
+    if os.name == 'nt':
+        monkeypatch.setenv("USERPROFILE", str(tmp_path))
     # Set BASIC_MEMORY_HOME to the test directory
     monkeypatch.setenv("BASIC_MEMORY_HOME", str(tmp_path / "basic-memory"))
     return tmp_path

tests/sync/test_tmp_files.py

@@ -122,7 +122,7 @@ async def test_rapid_atomic_writes(watch_service, project_config, test_project,
     await create_test_file(tmp2_path, "Second version")
 
     # Simulate the first atomic write
-    tmp1_path.rename(final_path)
+    tmp1_path.replace(final_path)
 
     # Brief pause to ensure file system registers the change
     await asyncio.sleep(0.1)
@@ -132,7 +132,7 @@ async def test_rapid_atomic_writes(watch_service, project_config, test_project,
     assert content1 == "First version"
 
     # Simulate the second atomic write
-    tmp2_path.rename(final_path)
+    tmp2_path.replace(final_path)
 
     # Verify content was updated
     content2 = final_path.read_text(encoding="utf-8")

tests/test_config.py

@@ -1,7 +1,7 @@
 """Test configuration management."""
 
 from basic_memory.config import BasicMemoryConfig
-
+from pathlib import Path
 
 class TestBasicMemoryConfig:
     """Test BasicMemoryConfig behavior with BASIC_MEMORY_HOME environment variable."""
@@ -15,7 +15,7 @@ def test_default_behavior_without_basic_memory_home(self, config_home, monkeypat
 
         # Should use the default path (home/basic-memory)
         expected_path = (config_home / "basic-memory").as_posix()
-        assert config.projects["main"] == expected_path
+        assert config.projects["main"] == Path(expected_path).as_posix()
 
     def test_respects_basic_memory_home_environment_variable(self, config_home, monkeypatch):
         """Test that config respects BASIC_MEMORY_HOME environment variable."""
@@ -38,7 +38,7 @@ def test_model_post_init_respects_basic_memory_home(self, config_home, monkeypat
 
         # model_post_init should have added main project with BASIC_MEMORY_HOME
         assert "main" in config.projects
-        assert config.projects["main"] == custom_path
+        assert config.projects["main"] == Path(custom_path).as_posix()
 
     def test_model_post_init_fallback_without_basic_memory_home(self, config_home, monkeypatch):
         """Test that model_post_init falls back to default when BASIC_MEMORY_HOME is not set."""
@@ -52,7 +52,7 @@ def test_model_post_init_fallback_without_basic_memory_home(self, config_home, m
         # model_post_init should have added main project with default path
         expected_path = (config_home / "basic-memory").as_posix()
         assert "main" in config.projects
-        assert config.projects["main"] == expected_path
+        assert config.projects["main"] == Path(expected_path).as_posix()
 
     def test_basic_memory_home_with_relative_path(self, config_home, monkeypatch):
         """Test that BASIC_MEMORY_HOME works with relative paths."""